Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conftest.py should be in tests folder #128

Closed
pberkes opened this issue Sep 20, 2024 · 3 comments · Fixed by #185
Closed

conftest.py should be in tests folder #128

pberkes opened this issue Sep 20, 2024 · 3 comments · Fixed by #185
Milestone

Comments

@pberkes
Copy link
Collaborator

pberkes commented Sep 20, 2024

otherwise tests cannot be run in the installed package

@otizonaizit
Copy link
Collaborator

I looked into it and it seems that adding a custom CLI option for pytest, as we do in conftest.py can not be done unless the file is in the top-level directory... I don't think there's an easy way out...

@lschwetlick
Copy link
Collaborator

lschwetlick commented Sep 24, 2024

I also just tried to research this, and didnt find a solution.

On the other hand, does anyone pip install a package, and then goes to the 20 levels of indirection within their environment to find that folder, and then runs the tests there?

I would have thought someone who wants to run the tests would, anyway, have cloned the git repo...

@otizonaizit otizonaizit added this to the v4.3 milestone Oct 7, 2024
@pberkes
Copy link
Collaborator Author

pberkes commented Oct 10, 2024

we decided to not move the tests out of the package, and not distribute them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants