Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Capacitor 4 support #131

Merged
merged 22 commits into from
Aug 25, 2022
Merged

Add Capacitor 4 support #131

merged 22 commits into from
Aug 25, 2022

Conversation

mraible
Copy link
Collaborator

@mraible mraible commented Aug 24, 2022

Fix #128.

Depends on martinkasa/capacitor-secure-storage-plugin#59.

In the meantime, you can clone the following repo in a directory alongside this repo and build it first.

git clone [email protected]:martinkasa/capacitor-secure-storage-plugin.git
cd capacitor-secure-storage-plugin
npm i
npm run build
npm pack

Currently, I see the following issue on iOS when I run npx cap open ios. I'm not sure how to fix.

⚡️  [error] - ERROR Error: Uncaught (in promise): Error: "Preferences" plugin is not implemented on ios
CapacitorException@capacitor://localhost/vendor.js:764:10
createPluginMethod@capacitor://localhost/vendor.js:886:37
@capacitor://localhost/vendor.js:895:40
onInvoke@capacitor://localhost/vendor.js:98549:31
@capacitor://localhost/polyfills.js:296:43
@capacitor://localhost/polyfills.js:1716:31
onInvokeTask@capacitor://localhost/vendor.js:98537:35
@capacitor://localhost/polyfills.js:353:49
drainMicroTaskQueue@capacitor://localhost/polyfills.js:823:32
promiseReactionJob@[native code]
⚡️  [error] - ERROR Error: Uncaught (in promise): Error: "Browser" plugin is not implemented on ios
CapacitorException@capacitor://localhost/vendor.js:764:10
createPluginMethod@capacitor://localhost/vendor.js:886:37
@capacitor://localhost/vendor.js:895:40
onInvoke@capacitor://localhost/vendor.js:98549:31
@capacitor://localhost/polyfills.js:296:43
@capacitor://localhost/polyfills.js:1716:31
onInvokeTask@capacitor://localhost/vendor.js:98537:35
@capacitor://localhost/polyfills.js:353:49
drainMicroTaskQueue@capacitor://localhost/polyfills.js:823:32
promiseReactionJob@[native code]

@mraible
Copy link
Collaborator Author

mraible commented Aug 24, 2022

I was able to fix these issues by running the following in my test app:

npm i @capacitor/[email protected] @capacitor/[email protected]
npx cap sync

@mraible mraible marked this pull request as ready for review August 24, 2022 18:00
@mraible
Copy link
Collaborator Author

mraible commented Aug 24, 2022

@wi3land Are you able to test the demos with an identity server? I assume you set something up locally to test things in the past?

@mraible
Copy link
Collaborator Author

mraible commented Aug 25, 2022

I was able to get most of the demos working, except for Angular + Cordova.

@mraible mraible marked this pull request as ready for review August 25, 2022 04:20
@mraible mraible merged commit d537691 into wi3land:master Aug 25, 2022
@mraible mraible deleted the capacitor-4 branch August 25, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capacitor V4 compatibility
2 participants