Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor V4 compatibility #128

Closed
richardkshergold opened this issue Aug 2, 2022 · 5 comments · Fixed by #131
Closed

Capacitor V4 compatibility #128

richardkshergold opened this issue Aug 2, 2022 · 5 comments · Fixed by #131

Comments

@richardkshergold
Copy link

I don't think this will be compatible with Capacitor 4 as the @capacitor/storage plugin has been renamed to @capacitor/preferences (the API remains the same)

@de-dan
Copy link
Contributor

de-dan commented Aug 2, 2022

This package can be made compatible with capacitor 4 as soon as this package capacitor-secure-storage-plugin is updated, as it currently depends on capacitor 3 directly.
I already created a PR there.

@richardkshergold richardkshergold changed the title Capacitor 4 plugin rename Capacitor 4 compatibility Aug 3, 2022
@richardkshergold richardkshergold changed the title Capacitor 4 compatibility Capacitor V4 compatibility Aug 3, 2022
@richardkshergold
Copy link
Author

Thanks for that @de-dan - I'm migrating our app to Capacitor 4 because of the change announced by Google re the API Limitations so presumably I need to wait for both of these libraries to be made V4 Compatible ?

@richardshergold
Copy link

I think the secure storage plugin PR has now been merged

@mraible
Copy link
Collaborator

mraible commented Aug 24, 2022

I tried to fix this today but ran into issues. Not sure how to fix it. See #131.

@mraible
Copy link
Collaborator

mraible commented Aug 25, 2022

I've figured out a fix, now I'm just testing the demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants