Skip to content

Re-flatten crate structure and get rid of PushService trait #978

Re-flatten crate structure and get rid of PushService trait

Re-flatten crate structure and get rid of PushService trait #978

GitHub Actions / clippy succeeded Oct 15, 2024 in 1s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 1731 in src/push_service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
    --> src/push_service.rs:1731:9
     |
1731 |     /// principle, they will consider any string as "unknown", so other strings may work too.
     |         ^
     |
     = help: if this is supposed to be its own paragraph, add a blank line
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
     |
1731 |     ///   principle, they will consider any string as "unknown", so other strings may work too.
     |         ++

Check warning on line 1730 in src/push_service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
    --> src/push_service.rs:1730:9
     |
1730 |     /// "android-2021-03" allegedly implies FCM support, whereas the other strings don't.  In
     |         ^
     |
     = help: if this is supposed to be its own paragraph, add a blank line
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
     = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
     |
1730 |     ///   "android-2021-03" allegedly implies FCM support, whereas the other strings don't.  In
     |         ++

Check warning on line 214 in src/push_service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `certificate` is never read

warning: field `certificate` is never read
   --> src/push_service.rs:214:5
    |
212 | struct SenderCertificateJson {
    |        --------------------- field in this struct
213 |     #[serde(with = "serde_base64")]
214 |     certificate: Vec<u8>,
    |     ^^^^^^^^^^^
    |
    = note: `SenderCertificateJson` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    = note: `#[warn(dead_code)]` on by default