Skip to content

Re-flatten crate structure and get rid of PushService trait #978

Re-flatten crate structure and get rid of PushService trait

Re-flatten crate structure and get rid of PushService trait #978

Triggered via pull request October 15, 2024 16:37
Status Success
Total duration 3m 34s
Artifacts

ci.yaml

on: pull_request
Check code formatting
5s
Check code formatting
Clippy
1m 9s
Clippy
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

45 warnings
Check code formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
doc list item without indentation: src/push_service.rs#L1731
warning: doc list item without indentation --> src/push_service.rs:1731:9 | 1731 | /// principle, they will consider any string as "unknown", so other strings may work too. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 1731 | /// principle, they will consider any string as "unknown", so other strings may work too. | ++
doc list item without indentation: src/push_service.rs#L1730
warning: doc list item without indentation --> src/push_service.rs:1730:9 | 1730 | /// "android-2021-03" allegedly implies FCM support, whereas the other strings don't. In | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 1730 | /// "android-2021-03" allegedly implies FCM support, whereas the other strings don't. In | ++
field `certificate` is never read: src/push_service.rs#L214
warning: field `certificate` is never read --> src/push_service.rs:214:5 | 212 | struct SenderCertificateJson { | --------------------- field in this struct 213 | #[serde(with = "serde_base64")] 214 | certificate: Vec<u8>, | ^^^^^^^^^^^ | = note: `SenderCertificateJson` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build (libsignal-service, Rust stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build (libsignal-service, Rust stable)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build (libsignal-service, Rust stable): src/push_service.rs#L214
field `certificate` is never read
Build (libsignal-service, Rust stable)
`libsignal-service` (lib) generated 1 warning
Build (libsignal-service, Rust stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust stable): src/push_service.rs#L214
field `certificate` is never read
Build (libsignal-service, Rust stable)
`libsignal-service` (lib) generated 1 warning
Build (libsignal-service, Rust beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build (libsignal-service, Rust beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build (libsignal-service, Rust beta): src/push_service.rs#L214
field `certificate` is never read
Build (libsignal-service, Rust beta)
`libsignal-service` (lib) generated 1 warning
Build (libsignal-service, Rust beta): src/push_service.rs#L214
field `certificate` is never read
Build (libsignal-service, Rust beta)
`libsignal-service` (lib) generated 1 warning
Build (libsignal-service, Rust beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build (libsignal-service, Rust nightly)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/[email protected], codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
the `-Cinline-threshold` flag is deprecated and does nothing (consider using `-Cllvm-args=--inline-threshold=...`)
Build (libsignal-service, Rust nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build (libsignal-service, Rust nightly): src/push_service.rs#L214
field `certificate` is never read
Build (libsignal-service, Rust nightly)
`libsignal-service` (lib test) generated 1 warning (1 duplicate)
Build (libsignal-service, Rust nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/