Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate /v1/queue/empty to clients #253

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Propagate /v1/queue/empty to clients #253

merged 1 commit into from
Oct 15, 2023

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Oct 9, 2023

This is a much smaller API breakage than I expected it to be and will be a massive quality of life improvements for clients of presage. It can also be used to properly wait for contacts sync.

Closes #94

@gferon gferon requested a review from rubdos October 9, 2023 08:47
@rubdos
Copy link
Member

rubdos commented Oct 9, 2023

Android has refactored this API too, and there they return lists of Envelopes in batches. They also have a system in place where Envelopes can be acknowledged, instead of acking them in the stream itself.

That said, I think this design is perfectly fine.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (aa84243) 3.71% compared to head (400b043) 3.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #253      +/-   ##
========================================
- Coverage   3.71%   3.71%   -0.01%     
========================================
  Files         38      38              
  Lines       2824    2825       +1     
========================================
  Hits         105     105              
- Misses      2719    2720       +1     
Files Coverage Δ
libsignal-service/src/websocket.rs 0.00% <0.00%> (ø)
libsignal-service/src/messagepipe.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gferon gferon merged commit 16695d0 into main Oct 15, 2023
10 of 11 checks passed
@gferon gferon deleted the end-of-queue branch October 15, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose /api/v1/queue/empty signal
2 participants