Account unlock tty #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match convention
Likely the fault of a misaligned test file path or flubby developer 'cp' keystroke. Solution: remove from vc.
Solution: write tests for each mem & persistent caches Note: Persistent accounts index cache uses file *name* (relative to keystore dir), while memory caching uses *absolute* path. This is to enable portability for indexed accounts keystore dir.
Solution: gofmt file
Solution: add comment
Solution: write test
Solution: delete it
Solution: refactor unlocking from startNode() to MakeNode() Resolves ethereumproject#247
Solution: 'defer' close immediately after opening Yields: Also remove commented tests that were frankensteined from cache in mem that are not relevant because they regard live-watching the keystore dir for filesystem changes, a feature which is not implemented in the persistent cache feature. Branch does: Fixes ethereumproject#247 Fixes ethereumproject#248
Solution: 'gofmt -w ./accounts/*.go'
Solution: parse sufficientChainConfig setter when making account manager Yields: Refactor logging, too.
Solution: only parse external config if flag is set
whilei
pushed a commit
that referenced
this pull request
Sep 15, 2017
whilei
force-pushed
the
master
branch
2 times, most recently
from
9da1fbc to
cf22a08
Compare
whilei
added a commit
that referenced
this pull request
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.