Problem: MustMakeChainDataDir func did not return absolute filepath

Solution: ensure absolute filepath

Problem #2: common.EnsureAbsolutePath misnamed; this func ensure absolute XOR
that specified paths are joined (that filepath is relative to a given dir)

Solution: #2: rename to EnsurePathAbsoluteOrRelativeTo

cmd/geth/flag.go

@@ -175,7 +175,15 @@ func mustMakeDataDir(ctx *cli.Context) string {
 // A subdir of the datadir is used for each chain configuration ("/mainnet", "/testnet", "/my-custom-net").
 // --> <home>/<EthereumClassic>/<mainnet|testnet|custom-net>, per --chain
 func MustMakeChainDataDir(ctx *cli.Context) string {
-	return common.EnsureAbsolutePath(mustMakeDataDir(ctx), getChainConfigIDFromContext(ctx))
+	rp := common.EnsurePathAbsoluteOrRelativeTo(mustMakeDataDir(ctx), getChainConfigIDFromContext(ctx))
+	if !filepath.IsAbs(rp) {
+		af, e := filepath.Abs(rp)
+		if e != nil {
+			glog.Fatalf("cannot make absolute path for chain data dir: %v: %v", rp, e)
+		}
+		rp = af
+	}
+	return rp
 }
 
 // MakeIPCPath creates an IPC path configuration from the set command line flags,
@@ -301,8 +309,14 @@ func MakeAccountManager(ctx *cli.Context) *accounts.Manager {
 	datadir := MustMakeChainDataDir(ctx)
 
 	keydir := filepath.Join(datadir, "keystore")
+
 	if path := ctx.GlobalString(aliasableName(KeyStoreDirFlag.Name, ctx)); path != "" {
-		keydir = path
+		af, e := filepath.Abs(path)
+		if e != nil {
+			glog.V(logger.Error).Infof("keydir path could not be made absolute: %v: %v", path, e)
+		} else {
+			keydir = af
+		}
 	}
 
 	m, err := accounts.NewManager(keydir, scryptN, scryptP, ctx.GlobalBool(aliasableName(AccountsIndexFlag.Name, ctx)))
@@ -912,7 +926,7 @@ func MakeConsolePreloads(ctx *cli.Context) []string {
 
 	assets := ctx.GlobalString(aliasableName(JSpathFlag.Name, ctx))
 	for _, file := range strings.Split(ctx.GlobalString(aliasableName(PreloadJSFlag.Name, ctx)), ",") {
-		preloads = append(preloads, common.EnsureAbsolutePath(assets, strings.TrimSpace(file)))
+		preloads = append(preloads, common.EnsurePathAbsoluteOrRelativeTo(assets, strings.TrimSpace(file)))
 	}
 	return preloads
 }

cmd/geth/main.go

@@ -303,7 +303,7 @@ func dumpChainConfig(ctx *cli.Context) error {
 
 	// pretty printy
 	cwd, _ := os.Getwd()
-	glog.V(logger.Info).Info(fmt.Sprintf("Dumping chain configuration JSON to \x1b[32m%s\x1b[39m, it may take a moment to tally genesis allocations...", common.EnsureAbsolutePath(cwd, chainConfigFilePath)))
+	glog.V(logger.Info).Info(fmt.Sprintf("Dumping chain configuration JSON to \x1b[32m%s\x1b[39m, it may take a moment to tally genesis allocations...", common.EnsurePathAbsoluteOrRelativeTo(cwd, chainConfigFilePath)))
 
 	db := MakeChainDatabase(ctx)
 

common/path.go

@@ -22,7 +22,7 @@ import (
 	"path/filepath"
 )
 
-func EnsureAbsolutePath(Datadir string, filename string) string {
+func EnsurePathAbsoluteOrRelativeTo(Datadir string, filename string) string {
 	if filepath.IsAbs(filename) {
 		return filename
 	}

internal/jsre/jsre.go

@@ -236,7 +236,7 @@ func (self *JSRE) Stop(waitForCallbacks bool) {
 // Exec(file) loads and runs the contents of a file
 // if a relative path is given, the jsre's assetPath is used
 func (self *JSRE) Exec(file string) error {
-	code, err := ioutil.ReadFile(common.EnsureAbsolutePath(self.assetPath, file))
+	code, err := ioutil.ReadFile(common.EnsurePathAbsoluteOrRelativeTo(self.assetPath, file))
 	if err != nil {
 		return err
 	}
@@ -282,7 +282,7 @@ func (self *JSRE) loadScript(call otto.FunctionCall) otto.Value {
 		// TODO: throw exception
 		return otto.FalseValue()
 	}
-	file = common.EnsureAbsolutePath(self.assetPath, file)
+	file = common.EnsurePathAbsoluteOrRelativeTo(self.assetPath, file)
 	source, err := ioutil.ReadFile(file)
 	if err != nil {
 		// TODO: throw exception

logger/log.go

@@ -26,7 +26,7 @@ import (
 )
 
 func openLogFile(datadir string, filename string) *os.File {
-	path := common.EnsureAbsolutePath(datadir, filename)
+	path := common.EnsurePathAbsoluteOrRelativeTo(datadir, filename)
 	file, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
 	if err != nil {
 		panic(fmt.Sprintf("error opening log file '%s': %v", filename, err))