Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BagProfile #67

Merged
merged 21 commits into from
Nov 19, 2024
Merged

Add BagProfile #67

merged 21 commits into from
Nov 19, 2024

Conversation

whikloj
Copy link
Owner

@whikloj whikloj commented Nov 19, 2024

Resolves #57

Add framework to load and validate a BagProfile, also allows for generating a Profile in code

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 71.80385% with 161 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5@633ce0e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Profiles/BagItProfile.php 72.50% 99 Missing ⚠️
src/Profiles/ProfileTags.php 0.00% 32 Missing ⚠️
src/Bag.php 82.30% 20 Missing ⚠️
src/Profiles/ProfileFactory.php 68.42% 6 Missing ⚠️
src/CurlInstance.php 89.74% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v5      #67   +/-   ##
=====================================
  Coverage      ?   83.98%           
  Complexity    ?      691           
=====================================
  Files         ?       11           
  Lines         ?     1898           
  Branches      ?        0           
=====================================
  Hits          ?     1594           
  Misses        ?      304           
  Partials      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@whikloj whikloj merged commit 3240fe9 into v5 Nov 19, 2024
17 checks passed
@whikloj whikloj deleted the feature/v5/profiles branch November 19, 2024 20:53
whikloj added a commit that referenced this pull request Nov 21, 2024
* Add workflow for version 4 development (#59)

* Remove support of PHP < 8.0 (#58)

* Remove support of PHP < 8.0

* More changes

* Add version 5 action

* More PHP 8 and phpstan fixes (#62)

* Add Tag Files functions (#65)

* Add addTagFile()

* Add removeTagFile and tests

* Build pushed feature branches

* Update action versions

* Fix messages

* Cover the new private function shared by addTagFile and removeTagFile

* Change bag to extended when adding a fetch file (#66)

* Add BagProfile (#67)

* Initial BagItProfile work

* More testing

* More tests

* Track serializations

* Load and validate profiles

* Return file path in archive type exception

* Windows test

* Clean up extension handling

* Add more profile tests

* Fixes and more profile tests

* Always check for Allow-Fetch before Require-Fetch, so the reverse test is unnecessary

* Fix callable in array_filter

* Move json into tests

* More tests

* Add methods to add profile to bag and some tests

* Allow other bag-info tag options

* Test bag is valid before creating a package

* Read BagIt Profile identifiers from bag-info.txt and validate

Additional tests

Handle long lines without a space to break at

* Add a change log

* Some tidying

* Correct PIPEWAIT and add test for trait

* Build on push and allow manual runs

* Clean up for PHPStan level 7 (#68)

* Clean up for PHPStan level 7

* Clean up some testing

* Prep for v5 merge

* Revert "Prep for v5 merge"

This reverts commit bd2b380.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant