More PHP 8 and phpstan fixes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5 #62 +/- ##
=====================================
Coverage ? 89.64%
Complexity ? 481
=====================================
Files ? 7
Lines ? 1381
Branches ? 0
=====================================
Hits ? 1238
Misses ? 143
Partials ? 0 ☔ View full report in Codecov by Sentry. |
whikloj
added a commit
that referenced
this pull request
Apr 12, 2024
whikloj
added a commit
that referenced
this pull request
Nov 21, 2024
* Add workflow for version 4 development (#59) * Remove support of PHP < 8.0 (#58) * Remove support of PHP < 8.0 * More changes * Add version 5 action * More PHP 8 and phpstan fixes (#62) * Add Tag Files functions (#65) * Add addTagFile() * Add removeTagFile and tests * Build pushed feature branches * Update action versions * Fix messages * Cover the new private function shared by addTagFile and removeTagFile * Change bag to extended when adding a fetch file (#66) * Add BagProfile (#67) * Initial BagItProfile work * More testing * More tests * Track serializations * Load and validate profiles * Return file path in archive type exception * Windows test * Clean up extension handling * Add more profile tests * Fixes and more profile tests * Always check for Allow-Fetch before Require-Fetch, so the reverse test is unnecessary * Fix callable in array_filter * Move json into tests * More tests * Add methods to add profile to bag and some tests * Allow other bag-info tag options * Test bag is valid before creating a package * Read BagIt Profile identifiers from bag-info.txt and validate Additional tests Handle long lines without a space to break at * Add a change log * Some tidying * Correct PIPEWAIT and add test for trait * Build on push and allow manual runs * Clean up for PHPStan level 7 (#68) * Clean up for PHPStan level 7 * Clean up some testing * Prep for v5 merge * Revert "Prep for v5 merge" This reverts commit bd2b380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.