Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes and maybe .editorconfig to other repositories #7

Closed
annevk opened this issue Jan 15, 2017 · 6 comments
Closed

Add .gitattributes and maybe .editorconfig to other repositories #7

annevk opened this issue Jan 15, 2017 · 6 comments

Comments

@annevk
Copy link
Member

annevk commented Jan 15, 2017

https://github.com/whatwg/html currently has both and it seems to make editing a little easier. It also makes it clear most code is HTML and not Shell. And setting diff=html makes diffs a little bit easier to read due to including headings in the context (reportedly, haven't seen it happen much).
@domenic
Copy link
Member

domenic commented Jan 17, 2017

+1, especially for .editorconfig.

@domenic
Copy link
Member

domenic commented Jan 23, 2017

I think this is an appropriate .gitattributes for our purposes:

*    text=auto eol=lf
*.bs diff=html linguist-language=HTML

I believe the first line says "for every file, detect if it's text using Git's normal heuristics. For every text file, normalize line endings to LF".

domenic added a commit to whatwg/url that referenced this issue Jan 23, 2017
@domenic
Add editorconfig and gitattributes
50eb8ad 
See whatwg/meta#7
@mathiasbynens
Copy link
Member

@domenic’s suggestion LGTM, although * text=auto implies eol=lf — just * text=auto is sufficient.

Big +1 to adding .editorconfig to every single repository. It’s one less thing to worry about for contributors.

domenic added a commit to whatwg/dom that referenced this issue Jan 24, 2017
@domenic
Meta: update spec deploy and editing infrastructure
68148f2 
- Updates to the deduplicated deploy script; part of whatwg/meta#6
- As such, stops deploying commit snapshots for branches; part of whatwg/meta#9
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
@domenic domenic mentioned this issue Jan 24, 2017
Merged
domenic added a commit to whatwg/dom that referenced this issue Jan 24, 2017
@domenic
Meta: update spec deploy and editing infrastructure
4c5c099 
- Updates to the deduplicated deploy script; part of whatwg/meta#6
- As such, stops deploying commit snapshots for branches; part of whatwg/meta#9
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/fetch that referenced this issue Feb 2, 2017
@annevk
Meta: update spec deploy and editing infrastructure
f609fdd 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
@annevk annevk mentioned this issue Feb 2, 2017
Merged
annevk added a commit to whatwg/fetch that referenced this issue Feb 7, 2017
@annevk
Meta: update spec deploy and editing infrastructure
948505d 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/infra that referenced this issue Feb 13, 2017
@annevk
Meta: update spec deploy and editing infrastructure
ab61d45 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
@annevk annevk mentioned this issue Feb 13, 2017
Merged
domenic pushed a commit to whatwg/infra that referenced this issue Feb 13, 2017
@annevk @domenic
Meta: update spec deploy and editing infrastructure
d147492 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/storage that referenced this issue Feb 15, 2017
@annevk
Meta: update spec deploy and editing infrastructure
e2455c7 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/notifications that referenced this issue Feb 15, 2017
@annevk
Meta: update spec deploy and editing infrastructure
6ecf595 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/fullscreen that referenced this issue Feb 15, 2017
@annevk
Meta: update spec deploy and editing infrastructure
0e17033 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/mimesniff that referenced this issue Feb 15, 2017
@annevk
Meta: update spec deploy and editing infrastructure
ad24d0b 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
annevk added a commit to whatwg/quirks that referenced this issue Feb 15, 2017
@annevk
Meta: update spec deploy and editing infrastructure
3fc9b98 
- Updates to the deduplicated deploy script; part of whatwg/meta#11
- As such, stops deploying commit snapshots for branches
- Fixes .travis.yml syntax; part of whatwg/meta#4
- Adds .gitattributes and .editorconfig; part of whatwg/meta#7
@annevk
Copy link
Member Author

annevk commented Mar 20, 2017

Streams, Console, and Loader still lack this.

domenic added a commit to whatwg/console that referenced this issue Mar 27, 2017
@domenic
Meta: add .editorconfig and .gitattributes
43c7f2b 
Part of whatwg/meta#7.
@domenic domenic mentioned this issue Mar 27, 2017
Merged
domenic added a commit to whatwg/console that referenced this issue Mar 27, 2017
@domenic
Meta: add .editorconfig and .gitattributes
b8dcda7 
Part of whatwg/meta#7.
domenic added a commit to whatwg/streams that referenced this issue Mar 29, 2017
@domenic
Meta: add .editorconfig and .gitattributes; update WPT
1cad77a 
Part of whatwg/meta#7.

Also removes an accidentally-committed test.js file.
@domenic domenic mentioned this issue Mar 29, 2017
Merged
domenic added a commit to whatwg/streams that referenced this issue Mar 29, 2017
@domenic
Meta: add .editorconfig and .gitattributes; update WPT
69457fe 
Part of whatwg/meta#7.

Also removes an accidentally-committed test.js file.
@domenic
Copy link
Member

domenic commented Mar 29, 2017

Streams and Console are now good to go. I think we should close and consider loader/books/figures/html-differences as a separate effort.

@annevk
Copy link
Member Author

annevk commented Mar 29, 2017

That sounds reasonable.

@annevk annevk closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathiasbynens @domenic @annevk