-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicating deploy scripts #6
Comments
We may also be able to roll the validator stuff into the deploy script |
I guess the only thing that would go away with this is local deployment. I guess that's not a big deal? |
I tried something at whatwg/url#205 but I'm again hitting the limitations of Travis documentation. |
Got it to work after taking a break. Things I'd like someone else to take on:
|
Here would be my to-do for early next week, building on your work:
I think whatwg/meta is better than resources.whatwg.org probably... not sure though, both are kind of overextending their boundaries. Maybe we should create a whatwg/build. |
What is the advantage of loading known_hosts each time? As long as we have a single server, it will only need a single entry. |
I don't understand this question. Why do you think my version is different from your version? Your version codes it into the build-script; mine allows it to be in a separate file. But they both load known_hosts the same number of times. It just seems cleaner to not inline files into other files with echo statements.
Right, "as long as we have a single server". But we don't: we have two right now (one for streams/console/a couple others, and one for everything else). And in general IMO it will be simpler to list all the hostnames in the file, with their corresponding keys, as that will make it easier to shift between servers in the future. |
Well, if you |
Hmm, I see. I'm not really concerned about multiple fetches, but maybe given that we have a single server it's simpler to just inline it... it's more of a pain to dig through the file and update, I guess, but oh well. |
If you really want a distinct resource, we could also use zip/unzip to avoid two fetches (until HTTP/2 is everywhere anyway). |
whatwg/url#205 is almost ready to go as a first pass. Still to-do is figuring out where to put the deploy.sh script, and changing the Makefile to allow local deploy. (The latter depends on the former.) After that we can start using it on the simple repos (i.e. those that only have the main spec file and maybe .htaccess). Then we can start working on the stuff mentioned in the OP to allow it to be used in more repos (e.g. those containing other files). |
Closes whatwg/meta#6 and closes whatwg/meta#9.
Closes whatwg/meta#6 and closes whatwg/meta#9.
OK, this should be ready for review: I also included editorconfig and gitattributes for URL where I was there, in the spirit of minimizing the number of meta commits. |
I'm not sure who would be best to review since you're the person with the most knowledge of this. Maybe @sideshowbarker can look if the shell script looks reasonable? I'll try to have a look anyway to see if I can spot anything. |
- Updates to the deduplicated deploy script; part of whatwg/meta#6 - As such, stops deploying commit snapshots for branches; part of whatwg/meta#9 - Fixes .travis.yml syntax; part of whatwg/meta#4 - Adds .gitattributes and .editorconfig; part of whatwg/meta#7
The building block for solving whatwg/meta#6 and whatwg/meta#9.
- Updates to the deduplicated deploy script; part of whatwg/meta#6 - As such, stops deploying commit snapshots for branches; part of whatwg/meta#9 - Fixes .travis.yml syntax; part of whatwg/meta#4 - Adds .gitattributes and .editorconfig; part of whatwg/meta#7
For the record, this all looks fine to me (sorry for not having responded here earlier). |
Related to #202, it's a bit annoying for every repo's commit history to contain a bunch of meta commits every time we want to update the deploy process. And, code duplication in general is bad.
Ideally we'd use the .travis.yml to set config variables:
I guess SHORTNAME could be inferred from some git commands to get the current repository and INPUT_FILE could be inferred to be the only .bs file in the repo.
We could then I guess have a simple one- or two-liner in Travis that curls down the deploy script from whatwg/meta and runs it.
I might try prototyping this early next week; feel free to start without me though (a good first pass would probably leave out FILES_GLOB and EMU_ALGIFY)
The text was updated successfully, but these errors were encountered: