Add a global event handler for beforeinput #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also imported the input event from the UI events specifications, since that one defines it. Fixes whatwg#4526 (This PR is directly pulled from whatwg#4530, which can't land due to IP issues.) (This PR is a replacement for whatwg#6743, which I neglected for too long.)
domenic
reviewed
Jun 8, 2022
|
Thanks for the review. This builds locally for me now, so hopefully it also will on the build server. |
|
Thanks for walking me through it! |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 12, 2022
See [1] for the landed spec PR, and [2] for the intent to ship. This adds `onbeforeinput` as a global event handler content attribute, to allow easy access to the 'beforeinput' event handler. [1] whatwg/html#7992 [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww Fixed: 947408 Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 Commit-Queue: Kent Tamura <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Xiaocheng Hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1023420}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 13, 2022
This reverts commit 1771acb. Reason for revert: Maybe caused event-handler-attributes-body-window.html failure https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/53607 Original change's description: > Add onbeforeinput global event handler attribute > > See [1] for the landed spec PR, and [2] for the intent to ship. > > This adds `onbeforeinput` as a global event handler content attribute, > to allow easy access to the 'beforeinput' event handler. > > [1] whatwg/html#7992 > [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww > > Fixed: 947408 > Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 > Commit-Queue: Kent Tamura <[email protected]> > Reviewed-by: Kent Tamura <[email protected]> > Auto-Submit: Mason Freed <[email protected]> > Reviewed-by: Xiaocheng Hu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1023420} Change-Id: Id4fdd3887cce72d682a819c4d0d55ee1f529f2c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758285 Auto-Submit: Keishi Hattori <[email protected]> Owners-Override: Keishi Hattori <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Keishi Hattori <[email protected]> Commit-Queue: Keishi Hattori <[email protected]> Cr-Commit-Position: refs/heads/main@{#1023523}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 14, 2022
This is a reland of commit 1771acb The original patch failed because of a few WPTs that needed rebaselining on a few platforms. At this point, this test [1] is still disabled, but I'll fix that after this lands and stabilizes. AFAIK it should just pass, but I'm tired of getting reverted. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=7207;drc=023841994d504cfa460fb1e9e474e31a4a38a240 Fixed: 947408 Bug: 1344128 Original change's description: > Add onbeforeinput global event handler attribute > > See [1] for the landed spec PR, and [2] for the intent to ship. > > This adds `onbeforeinput` as a global event handler content attribute, > to allow easy access to the 'beforeinput' event handler. > > [1] whatwg/html#7992 > [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww > > Fixed: 947408 > Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 > Commit-Queue: Kent Tamura <[email protected]> > Reviewed-by: Kent Tamura <[email protected]> > Auto-Submit: Mason Freed <[email protected]> > Reviewed-by: Xiaocheng Hu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1023420} Change-Id: I3fb8184864cb9590ec310487482004d53939c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760865 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1024116}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
See [1] for the landed spec PR, and [2] for the intent to ship. This adds `onbeforeinput` as a global event handler content attribute, to allow easy access to the 'beforeinput' event handler. [1] whatwg/html#7992 [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww Fixed: 947408 Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 Commit-Queue: Kent Tamura <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Xiaocheng Hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1023420} NOKEYCHECK=True GitOrigin-RevId: 1771acb252e1265ba2c935e5662c912f1a40c4f4
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This reverts commit 1771acb252e1265ba2c935e5662c912f1a40c4f4. Reason for revert: Maybe caused event-handler-attributes-body-window.html failure https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/53607 Original change's description: > Add onbeforeinput global event handler attribute > > See [1] for the landed spec PR, and [2] for the intent to ship. > > This adds `onbeforeinput` as a global event handler content attribute, > to allow easy access to the 'beforeinput' event handler. > > [1] whatwg/html#7992 > [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww > > Fixed: 947408 > Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 > Commit-Queue: Kent Tamura <[email protected]> > Reviewed-by: Kent Tamura <[email protected]> > Auto-Submit: Mason Freed <[email protected]> > Reviewed-by: Xiaocheng Hu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1023420} Change-Id: Id4fdd3887cce72d682a819c4d0d55ee1f529f2c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758285 Auto-Submit: Keishi Hattori <[email protected]> Owners-Override: Keishi Hattori <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Keishi Hattori <[email protected]> Commit-Queue: Keishi Hattori <[email protected]> Cr-Commit-Position: refs/heads/main@{#1023523} NOKEYCHECK=True GitOrigin-RevId: fd399d2e58b2581fc5e72ed0d8831533a949499e
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This is a reland of commit 1771acb252e1265ba2c935e5662c912f1a40c4f4 The original patch failed because of a few WPTs that needed rebaselining on a few platforms. At this point, this test [1] is still disabled, but I'll fix that after this lands and stabilizes. AFAIK it should just pass, but I'm tired of getting reverted. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=7207;drc=023841994d504cfa460fb1e9e474e31a4a38a240 Fixed: 947408 Bug: 1344128 Original change's description: > Add onbeforeinput global event handler attribute > > See [1] for the landed spec PR, and [2] for the intent to ship. > > This adds `onbeforeinput` as a global event handler content attribute, > to allow easy access to the 'beforeinput' event handler. > > [1] whatwg/html#7992 > [2] https://groups.google.com/a/chromium.org/g/blink-dev/c/hOhg-Rw6qww > > Fixed: 947408 > Change-Id: I6290253eab2bbfb652e8d3e17e4be655da9ccde5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749794 > Commit-Queue: Kent Tamura <[email protected]> > Reviewed-by: Kent Tamura <[email protected]> > Auto-Submit: Mason Freed <[email protected]> > Reviewed-by: Xiaocheng Hu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1023420} Change-Id: I3fb8184864cb9590ec310487482004d53939c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760865 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1024116} NOKEYCHECK=True GitOrigin-RevId: e1520674d52e837b3a6688fc778d590ed0c0695f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also imported the input event from the UI events specifications, since that one defines it.
Fixes #4526
(This PR is directly pulled from #4530, which can't land due to IP issues.)
(This PR is a replacement for #6743, which I neglected for too long.)
/browsing-the-web.html ( diff )
/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/webappapis.html ( diff )