Added a global event handler for beforeinput #4530

phistuck · 2019-04-12T21:15:17Z

Also imported the input event from the UI events
specifications, since that one defines it.

Fixed #4526

💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:59 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

<html>
<head><title>504 Gateway Time-out</title></head>
<body bgcolor="white">
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.10.3</center>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Also imported the input event from the UI events specification, since that one defines it. Fixed whatwg#4526

sideshowbarker

LGTM

sideshowbarker · 2019-04-13T07:53:15Z

heads-up @whatwg/documentation

source

chrisdavidmills · 2019-04-15T09:00:17Z

Documentation potential need recorded at https://trello.com/c/aBs1o6Pg/86-dom-general-enhancements-fx-67

to clarify their intents.

annevk

Thanks, so what remains here:

Implementer interest if not implemented.
Implementer bugs if not implemented.
WPT coverage. (I guess we get some automatically through IDL, maybe enough?)

phistuck · 2019-04-17T12:00:55Z

@annevk - and verifying my participation.

Looks like WebKit added it already, without adding it to the standard -
https://trac.webkit.org/changeset/206944/webkit#file12
They added it to Element and Document, rather than to GlobalEventHandlers -
https://github.com/WebKit/webkit/blob/master/Source/WebCore/dom/DocumentAndElementEventHandlers.idl
They also seem to have added support for it as a content attribute (should new events be added as content attributes? I assumed not) -
https://github.com/WebKit/webkit/blob/master/Source/WebCore/html/HTMLAttributeNames.in

Chromium issue - https://bugs.chromium.org/p/chromium/issues/detail?id=947408

An intention by Mozilla to add it when they implement beforeinput -
w3c/uievents#218 (comment)

phistuck · 2019-04-17T12:01:49Z

@annevk - regarding tests, yes, I assumed IDLs are automatically tested.

annevk · 2019-04-18T08:18:53Z

Ah yeah, it should be a content attribute as well.

phistuck · 2019-04-18T08:24:07Z

@annevk - I will add it in the UTC+2 evening. Anything else left other than the content attribute and verifying my participation?

annevk · 2019-04-18T09:16:37Z

No, I think we're good then, thanks! I'll verify you now.

phistuck · 2019-04-18T16:17:56Z

@annevk -

Ah yeah, it should be a content attribute as well.

Unrelated, but why does DOMContentLoaded not have an IDL/content attribute, too?

I added the content attribute.

One more thing, is adding my name to the acknowledgement section mandatory? I assumed it was, so I added, but I generally rather not if it is possible.

domenic · 2019-04-23T01:47:19Z

I'm not sure this should be verified, as I don't believe signing a contract using a pseudonym is viable legally...

phistuck · 2019-04-23T07:16:19Z

@domenic - Google was fine with it, jQuery was fine with it (they did consult first) and maybe a few more I signed (RavenDB was not fine but only because they required an exact address and phone number which I am not willing to provide). But if you have an issue with that, I hereby release all rights for my change and you or anyone else is welcome to take it as their own, no credit needed.

annevk · 2019-04-23T14:07:05Z

@domenic I've verified other pseudonym-like names. Also, without ID verification of some kind many others could be pseudonyms too?

annevk · 2019-04-23T14:09:47Z

@phistuck adding your name to the Acknowledgments section is optional, feel free to remove it. DOMContentLoaded could maybe have an event handler attribute too. I think historically we might have tried to steer folks away from event handler attributes, but there's no real good reason to do so. One problem there is that the event name is not lowercase, but the event handler needs to be. That'd be a first and might be problematic for some implementations. Best discussed separately.

phistuck · 2019-04-23T18:21:30Z

@annevk - done.

Thank you for the review, everyone.

phistuck · 2019-04-30T16:23:22Z

@annevk and @domenic - is there anything else that is needed for this to be merged?

Like I mentioned, if there is a legal issue here, feel free to take the change as your own, credit-attribution-acknowledgement free, I am waiving all rights.

phistuck · 2019-07-15T14:15:24Z

@annevk and @domenic - from the agreement status page -

After an agreement is submitted, it is verified by the WHATWG. This is a manual process, but is usually completed quickly if it's preventing a pull request from being accepted.

This is preventing a pull request from being accepted for three months. It would be great if you expedited the process.

domenic · 2019-07-15T15:14:29Z

We are blocked on confirmation from the SG as to whether pseudonyms are acceptable. This is out of our hands. We can close the PR if that's preferable to you.

mfreed7 · 2021-04-19T20:51:36Z

Any update on this and #4526? Seems a shame to not be able to land the PRs over names vs. pseudonyms. Can we land this under a different name, or does a fresh PR need to be made?

domenic · 2021-04-19T22:11:34Z

A fresh PR is probably the best way forward.

phistuck · 2021-04-19T22:57:18Z

@mfreed7 - sure, go for it, let me know when you have and I will close this one.

mfreed7 · 2021-06-07T17:47:49Z

@mfreed7 - sure, go for it, let me know when you have and I will close this one.

#6743

Also imported the input event from the UI events specifications, since that one defines it. Fixes whatwg#4526 (This PR is directly pulled from whatwg#4530, which can't land due to IP issues.) (This PR is a replacement for whatwg#6743, which I neglected for too long.)

Added a global event handler for beforeinput

ac85f86

Also imported the input event from the UI events specification, since that one defines it. Fixed whatwg#4526

phistuck force-pushed the beforeinput branch from 963f812 to ac85f86 Compare April 12, 2019 21:16

sideshowbarker approved these changes Apr 13, 2019

View reviewed changes

sideshowbarker added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Apr 13, 2019

annevk reviewed Apr 15, 2019

View reviewed changes

source Show resolved Hide resolved

phistuck added 3 commits April 15, 2019 19:46

Fixed the interesting targets for input and beforeinput

4761bab

Updated the description of the input and beforeinput events

82c254c

to clarify their intents.

Clarified beforeinput and input further.

952332a

annevk approved these changes Apr 17, 2019

View reviewed changes

Added onbeforeinput as a content attribute.

aa84849

Removed my name from the acknowledgements.

d2b2e0f

annevk assigned domenic May 2, 2019

domenic mentioned this pull request May 20, 2019

Can contributors use pseudonyms to sign the participation agreement? whatwg/sg#93

Closed

Base automatically changed from master to main January 15, 2021 07:57

mfreed7 added a commit to mfreed7/html that referenced this pull request Jun 7, 2021

Manually apply whatwg#4530

f7258f3

mfreed7 mentioned this pull request Jun 7, 2021

Add a global event handler for beforeinput #6743

Closed

annevk closed this Jun 17, 2021

mfreed7 mentioned this pull request Jun 7, 2022

Add a global event handler for beforeinput #7992

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a global event handler for beforeinput #4530

Added a global event handler for beforeinput #4530

phistuck commented Apr 12, 2019 •

edited by pr-preview bot

Loading

sideshowbarker left a comment

sideshowbarker commented Apr 13, 2019

chrisdavidmills commented Apr 15, 2019

annevk left a comment •

edited

Loading

phistuck commented Apr 17, 2019 •

edited

Loading

phistuck commented Apr 17, 2019

annevk commented Apr 18, 2019

phistuck commented Apr 18, 2019

annevk commented Apr 18, 2019

phistuck commented Apr 18, 2019

domenic commented Apr 23, 2019

phistuck commented Apr 23, 2019 •

edited

Loading

annevk commented Apr 23, 2019

annevk commented Apr 23, 2019

phistuck commented Apr 23, 2019

phistuck commented Apr 30, 2019

phistuck commented Jul 15, 2019

domenic commented Jul 15, 2019

mfreed7 commented Apr 19, 2021

domenic commented Apr 19, 2021

phistuck commented Apr 19, 2021

mfreed7 commented Jun 7, 2021

Added a global event handler for beforeinput #4530

Added a global event handler for beforeinput #4530

Conversation

phistuck commented Apr 12, 2019 • edited by pr-preview bot Loading

💥 Error: Wattsi server error 💥

sideshowbarker left a comment

Choose a reason for hiding this comment

sideshowbarker commented Apr 13, 2019

chrisdavidmills commented Apr 15, 2019

annevk left a comment • edited Loading

Choose a reason for hiding this comment

phistuck commented Apr 17, 2019 • edited Loading

phistuck commented Apr 17, 2019

annevk commented Apr 18, 2019

phistuck commented Apr 18, 2019

annevk commented Apr 18, 2019

phistuck commented Apr 18, 2019

domenic commented Apr 23, 2019

phistuck commented Apr 23, 2019 • edited Loading

annevk commented Apr 23, 2019

annevk commented Apr 23, 2019

phistuck commented Apr 23, 2019

phistuck commented Apr 30, 2019

phistuck commented Jul 15, 2019

domenic commented Jul 15, 2019

mfreed7 commented Apr 19, 2021

domenic commented Apr 19, 2021

phistuck commented Apr 19, 2021

mfreed7 commented Jun 7, 2021

phistuck commented Apr 12, 2019 •

edited by pr-preview bot

Loading

annevk left a comment •

edited

Loading

phistuck commented Apr 17, 2019 •

edited

Loading

phistuck commented Apr 23, 2019 •

edited

Loading