Remove "responsible document" concept #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was confusing to have this as a generic on environment settings objects, since it only applied to window environment settings objects. Instead, specifications should get the Window object's associated Document directly, if necessary by looking at the settings object's global object (which will, in some cases, be a Window object). Closes #4335.
IMO, yes, and file issues (or PRs) for all affected specs. |
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 10, 2022
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 11, 2022
This was referenced Mar 11, 2022
Editorial: use associated Document in place of responsible document
WebBluetoothCG/web-bluetooth#579
Merged
Merged
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 15, 2022
This was referenced Mar 15, 2022
Open
This was referenced Mar 15, 2022
Merged
|
@domenic I think there should be a PR or an issue for everything under https://dontcallmedom.github.io/webdex/r.html#responsible%20document%40%40environment%20settings%20object%40dfn now (xhr still shows up, but I think that's due to whatwg/xhr#345) |
|
OMG, thank you so much for doing all that work; that's amazing! |
annevk
approved these changes
Mar 16, 2022
rsolomakhin
added a commit
to WICG/digital-goods
that referenced
this pull request
Mar 18, 2022
Use associated Document in place of responsible document, because the latter concept was removed. cf. whatwg/html#7694
johannhof
added a commit
to johannhof/feature-policy
that referenced
this pull request
Mar 24, 2022
clelland
pushed a commit
to w3c/webappsec-permissions-policy
that referenced
this pull request
Mar 25, 2022
* Replace usage of "responsible document" See whatwg/html#7694 * Use the relevant global object
1 task
Bishwarupjee
pushed a commit
to Bishwarupjee/xhr
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was confusing to have this as a generic on environment settings objects, since it only applied to window environment settings objects. Instead, specifications should get the Window object's associated Document directly, if necessary by looking at the settings object's global object (which will, in some cases, be a Window object).
Closes #4335.
Per WebDex this term is used a lot!! I'm unsure what we should do here. Just merge and break a bunch of specs? (We've done it in the past, but now we have WebDex to tell us how much damage we'd cause!) Preserve the ID, perhaps on concept-document-window? Prepare PRs for at least WHATWG specs like Compat and XHR?
Specific migration guide:
Windowobject, use|window|'s [=associated Document=]instead.[=this=]value), use|object|'s [=relevant global object=]'s [=associated Document=].|eso|'s [=environment settings object/global object=] is a {{Window}}.|object|'s [=relevant global object=] is a {{Window}}.Return [=this=]'s [=relevant global object=]'s [=associated Document=]./history.html ( diff )
/rendering.html ( diff )
/web-messaging.html ( diff )
/webappapis.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )