HTML parser: make breaking out of foreign content apply in innerHTML #6399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to match Chromium and WebKit. Fixes #5117.
zcorpan
force-pushed
the
bocoup/fragment-parsing-svg-p
branch
from
83a34e2
to
1d271f2
Compare
|
Thanks @zcorpan, here's an old Gecko implementation bug, which ought to be repurposed https://bugzilla.mozilla.org/show_bug.cgi?id=1205631 |
|
Great, thanks @mozfreddyb. I plan to write tests for this on Friday this week, unless someone else beats me to it. :) |
|
/cc @whatwg/html-parser; it'd be ideal to get review from one of those folks too, although this seems simple enough :) |
domenic
added
interop
|
LGTM. Thanks. |
domenic
approved these changes
Feb 23, 2021
zcorpan
added a commit
to zcorpan/html5lib-tests
that referenced
this pull request
Feb 26, 2021
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 26, 2021
See html5lib/html5lib-tests#133 Spec change: whatwg/html#6399 To regenerate the tests with Python3 requires this change: #27798
|
I've created 3 PRs to update tests for this: |
|
Tests indeed match 2/3 browsers, so please merge at will! I hope someone more familiar with html5lib and the surrounding infrastructure can review the test PRs... |
|
I'm happy with the tests, but I'm no longer an html5lib peer it seems. Paging @gsnedders and @jgraham. |
3 tasks
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 29, 2021
TRowbotham
added a commit
to TRowbotham/PHPDOM
that referenced
this pull request
Apr 1, 2021
Fixes html tags being nested inside svg and math tags. Uses the proposed spec changes from whatwg/html#6399 and whatwg/html#6455
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 2, 2021
…ith html5lib-tests#133, a=testonly Automatic update from web-platform-tests HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 See html5lib/html5lib-tests#133 Spec change: whatwg/html#6399 -- wpt-commits: 44e250d007a5c795e9005b34ac33ee966195190b wpt-pr: 27799
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 2, 2021
…ith html5lib-tests#133, a=testonly Automatic update from web-platform-tests HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 See html5lib/html5lib-tests#133 Spec change: whatwg/html#6399 -- wpt-commits: 44e250d007a5c795e9005b34ac33ee966195190b wpt-pr: 27799
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 7, 2021
…ith html5lib-tests#133, a=testonly Automatic update from web-platform-tests HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 See html5lib/html5lib-tests#133 Spec change: whatwg/html#6399 -- wpt-commits: 44e250d007a5c795e9005b34ac33ee966195190b wpt-pr: 27799
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 8, 2021
…ith html5lib-tests#133, a=testonly Automatic update from web-platform-tests HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 See html5lib/html5lib-tests#133 Spec change: whatwg/html#6399 -- wpt-commits: 44e250d007a5c795e9005b34ac33ee966195190b wpt-pr: 27799
3 tasks
stevecheckoway
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Oct 13, 2021
The first comment is incorrect. The fragment case was changed to match the nonfragment case in whatwg/html#6399. This introduced a bug that was noted by the second comment indicating that the parser diverged from the standard to fix the bug. The standard was subsequently fixed in whatwg/html#6455, obviating the comment.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
The regression was introduced in f690ad9 (whatwg#6399). For the case: <table><math><p>foo the <p> token would not have foster parenting enabled, thus inserting it into the table. Fixes whatwg#6439.
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 20, 2024
…Parser` Firefox has a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1205631 where assignment to `innerHTML` produces a different DOM tree than passing the HTML to `document.write()`; other browsers use the same algorithm in both places, the same one Firefox uses for `document.write()`. Firefox's behavior used to be spec-compliant but the spec changed in: whatwg/html#6399 Because `$.parseHTML` used to use: ```js document.implementation.createHTMLDocument( "" ) ``` followed by an `innerHTML` assignment under the hood, Firefox was hitting that issue. TODO we cannot pass `data` to `parseFromString` like that as it goes through `buildFragment` later anyway. Ref whatwg/html#5117 Ref whatwg/html#6399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to match Chromium and WebKit.
Fixes #5117.
<svg><p>in innerHTML)<svg><p>in innerHTML: Sync with html5lib-tests#133(See WHATWG Working Mode: Changes for more details.)
/parsing.html ( diff )