Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 #27799

Merged
merged 2 commits into from
Mar 29, 2021
Merged

HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 #27799

merged 2 commits into from
Mar 29, 2021

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 26, 2021

See html5lib/html5lib-tests#133

Spec change: whatwg/html#6399

To regenerate the tests with Python3 requires this change: #27798

@zcorpan
HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133
a3aa001 
See html5lib/html5lib-tests#133

Spec change: whatwg/html#6399

To regenerate the tests with Python3 requires this change: #27798
@zcorpan zcorpan mentioned this pull request Feb 26, 2021
Merged
3 tasks
@zcorpan
Copy link
Member Author

zcorpan commented Feb 26, 2021

When html5lib/html5lib-tests#133 is merged the commit hash in html/tools/build.sh needs to be updated (and regenerate tests if there were changes).

@zcorpan
Copy link
Member Author

zcorpan commented Mar 2, 2021

The hash is for the html5lib-python repo, not html5lib-tests, so though the tests are now merged in html5lib-tests, we also need to update the submodule in html5lib-python. I created a PR for that at html5lib/html5lib-python#531 ´

@zcorpan zcorpan mentioned this pull request Mar 2, 2021
Open
@zcorpan
Copy link
Member Author

zcorpan commented Mar 29, 2021 •
edited
Loading

html5lib/html5lib-python#531

That is now merged.

the commit hash in html/tools/build.sh needs to be updated (and regenerate tests if there were changes).

Done.

@zcorpan zcorpan merged commit 44e250d into master Mar 29, 2021
@zcorpan zcorpan deleted the bocoup/sync-html5lib-svg-p-innerhtml branch March 29, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@annevk annevk

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @annevk @wpt-pr-bot