More fixes for FACE attribute issues #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
topic: custom elements
annevk
approved these changes
Oct 19, 2019
* Adds an annotation to prevent "is" and "dir" from getting over-explained, per whatwg/html-build#210. * Removes the double description of the disabled attribute (attr-fe-disabled), once for form elements and once for form-associated custom elements. There is only one <dfn> so there should be only one attribute index entry.
domenic
force-pushed
the
more-face-readonly-corrections
branch
from
1024799 to
2fe8ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here is a normative addition of authoring advice. The second is more mechanical tweaks.
These should probably be merged around the same time as whatwg/html-build#210, ideally right after. I'm happy to also throw in fixes for the
dirattribute annotations as discussed in that PR, if we agree on which way to fix it./custom-elements.html ( diff )
/indices.html ( diff )