-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attribute annotation code for FACEs #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several related issues: * `<span>form-associated custom elements</span>` was not matching the regex that was looking for `<code>` in the attribute index. * Changing the regex to look for span or code causes many other lines to be picked up. Thus, we introduce the new 'tr' state into the state machine to better detect the first line of a <tr>. * Even with that, we were now dying on global attributes, since they don't have a domintro to get substituted in to. So we remove that error state. * Finally, we were now substituting in even in cases that just mention the attribute, like "Global attributes, except the is attribute". So, we need to add an escape hatch for that.
domenic
added a commit
to whatwg/html
that referenced
this pull request
Oct 19, 2019
* Adds an annotation to prevent "is" from getting over-explained, per whatwg/html-build#210. * Removes the double description of the disabled attribute (attr-fe-disabled), once for form elements and once for form-associated custom elements. There is only one <dfn> so there should be only one attribute index entry.
annevk
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mike should probably review the Perl, but this sounds good to me.
sideshowbarker
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this
domenic
added a commit
to whatwg/html
that referenced
this pull request
Oct 19, 2019
* Adds an annotation to prevent "is" and "dir" from getting over-explained, per whatwg/html-build#210. * Removes the double description of the disabled attribute (attr-fe-disabled), once for form elements and once for form-associated custom elements. There is only one <dfn> so there should be only one attribute index entry.
domenic
added a commit
to whatwg/html
that referenced
this pull request
Oct 19, 2019
* Adds an annotation to prevent "is" and "dir" from getting over-explained, per whatwg/html-build#210. * Removes the double description of the disabled attribute (attr-fe-disabled), once for form elements and once for form-associated custom elements. There is only one <dfn> so there should be only one attribute index entry.
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 6, 2019
* Adds an annotation to prevent "is" and "dir" from getting over-explained, per whatwg/html-build#210. * Removes the double description of the disabled attribute (attr-fe-disabled), once for form elements and once for form-associated custom elements. There is only one <dfn> so there should be only one attribute index entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue fixed here is that the domintro for custom elements was not properly listing the attribute explanation for
readonly
.This fixes several related issues:
<span>form-associated custom elements</span>
was not matching theregex that was looking for
<code>
in the attribute index.be picked up. Thus, we introduce the new 'tr' state into the state
machine to better detect the first line of a
<tr>
.don't have a domintro to get substituted in to. So we remove that
error state.
the attribute, like "Global attributes, except the is attribute". So,
we need to add an escape hatch for that.
I've tested that this produces the following diff on the full spec:
For
dir
, we can either add<!-- no-annotate -->
, or we can add actually special definitions forbdi
andbdo
.