Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video.removeTextTrack() method #2881

Closed
wants to merge 1 commit into from
Closed

Add video.removeTextTrack() method #2881

wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 1, 2017

<ol>
<li><p>If <var>textTrack</var> is not in the <span>media element</span>'s <span>list of text
tracks</span>, then throw a <span>"<code>NotFoundError</code>"</span> <code>DOMException</code>
and abort these steps.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: no need for "and abort these steps" these days. See #2878

steps:</p>

<ol>
<li><p>If <var>textTrack</var> is not in the <span>media element</span>'s <span>list of text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate design: return without throwing. Not sure which is better.

<li><p><span>Queue a task</span> to <span data-x="concept-event-fire">fire an event</span> named
<code data-x="event-media-removetrack">removetrack</code> at the <span>media element</span>'s
<code data-x="dom-media-textTracks">textTracks</code> attribute's <code>TextTrackList</code>
object, using <code>TrackEvent</code>, with the <code data-x="dom-TrackEvent-track">track</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the textTracks attribute is a TextTrackList object, this doesn't seem right. Maybe just omit 's TextTrackList object.

@domenic domenic added addition/proposal New features or enhancements topic: media do not merge yet Pull request must not be merged per rationale in comment labels Aug 1, 2017
@domenic
Copy link
Member

domenic commented Aug 3, 2017

Tagging "do not merge yet" until TODOs are resolved.

@OrenMe
Copy link

OrenMe commented Aug 17, 2020

Hi, wanted to raise awareness that this still matters.
Is there a way to help move this forward?

@foolip
Copy link
Member Author

foolip commented Aug 26, 2020

@OrenMe as you can see it was 3 years since I opened this, and I haven't taken the time to finish it in that time. I will go ahead and close it to reflect that I'm not going to prioritize this, but someone else could take parts of this and start over in a new pull request.

@foolip foolip closed this Aug 26, 2020
@foolip foolip deleted the removeTextTrack branch August 26, 2020 07:04
@silviapfeiffer
Copy link

Has this been implemented in browsers?

@foolip
Copy link
Member Author

foolip commented Aug 26, 2020

I don't think so, since there's no spec for it :)

(This wasn't a case of retro-specing a feature already shippped.)

@gkatsev
Copy link

gkatsev commented Aug 26, 2020

It's definitely something that a lot of player devs are still interested in.

Definitely makes sense for someone else to pick up the torch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements do not merge yet Pull request must not be merged per rationale in comment topic: media
Development

Successfully merging this pull request may close these issues.

No video.removeTextTrack method
5 participants