-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video.removeTextTrack() method #2881
Conversation
<ol> | ||
<li><p>If <var>textTrack</var> is not in the <span>media element</span>'s <span>list of text | ||
tracks</span>, then throw a <span>"<code>NotFoundError</code>"</span> <code>DOMException</code> | ||
and abort these steps.</p></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: no need for "and abort these steps" these days. See #2878
steps:</p> | ||
|
||
<ol> | ||
<li><p>If <var>textTrack</var> is not in the <span>media element</span>'s <span>list of text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate design: return without throwing. Not sure which is better.
<li><p><span>Queue a task</span> to <span data-x="concept-event-fire">fire an event</span> named | ||
<code data-x="event-media-removetrack">removetrack</code> at the <span>media element</span>'s | ||
<code data-x="dom-media-textTracks">textTracks</code> attribute's <code>TextTrackList</code> | ||
object, using <code>TrackEvent</code>, with the <code data-x="dom-TrackEvent-track">track</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the textTracks attribute is a TextTrackList object, this doesn't seem right. Maybe just omit 's TextTrackList object
.
Tagging "do not merge yet" until TODOs are resolved. |
Hi, wanted to raise awareness that this still matters. |
@OrenMe as you can see it was 3 years since I opened this, and I haven't taken the time to finish it in that time. I will go ahead and close it to reflect that I'm not going to prioritize this, but someone else could take parts of this and start over in a new pull request. |
Has this been implemented in browsers? |
I don't think so, since there's no spec for it :) (This wasn't a case of retro-specing a feature already shippped.) |
It's definitely something that a lot of player devs are still interested in. Definitely makes sense for someone else to pick up the torch. |
Fixes #1921
Tests: web-platform-tests/wpt#6594