-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "abort these steps" wording #2878
Comments
Progress! After 7ebc44a, many of these are gone. 71 remain, and some of them are legitimate, e.g. they occur inside "in parallel" steps (for which return/throw don't work). But others should be replaced, e.g. the one in drawImage() or the ImageData constructor. (ImageData even has a "throw an ... and return"; we should remove the "and return".) So there's still some work to do here. |
Hello! I would like to work on this issue. @domenic |
Great! Check out https://github.com/whatwg/html/blob/master/CONTRIBUTING.md to get set up. Then, try to find all instances of "abort these steps" and replace them with "return". Some of them need to stay "abort these steps", but we can point those out when you get to them. |
@domenic Please assign me for this issue. |
@shreyateeza GitHub doesn't let me do that, but no fear, you've stated this issue is yours; nobody else will take it :). You can work on it without being assigned. |
…these steps' Closes whatwg#2878
…these steps'. Closes whatwg#2878
…these steps'. Closes whatwg#2878
…these steps'. Closes whatwg#2878
…these steps'. Closes whatwg#2878
…these steps'. Closes whatwg#2878
This replaces "abort these steps" with "return" and removes redundant "abort these steps". Closes #2878.
This replaces "abort these steps" with "return" and removes redundant "abort these steps". Closes whatwg#2878.
In Infra, we have clarified that "return" or "throw" aborts the algorithm it is in. This convention was adopted after much of the prose in the HTML Standard was written, so HTML contains many now-redundant sequences like
or
These should remove the redundant "and abort these steps". Similarly, cases like
should be converted to replace "Abort these steps" with "Return".
Doing so helps set a good example, and reduce confusion for people who read HTML (which is currently a mix of the new style and the old style).
There are currently 427 instances of "abort these steps". If any of them seem tricky, feel free to leave them in and we can take care of them later. Just getting the straightforward ones is a big enough task.
(This is part of #2053)
The text was updated successfully, but these errors were encountered: