rangefeed: remove LegacyProcessor

The ScheduledProcessor has been in default use since 24.1, substantially out performs the LegacyProcessor, and is the likely place that new improvements will be implemented. Here, we remove the LegacyProcessor, retiring the associated cluster setting. This is similar to cockroachdb#114410, but reconstructed from scratch. Epic: none Release note (ops change): The setting kv.rangefeed.scheduler.enabled has been retired. The rangefeed scheduler is now unconditionally enabled. Co-authored-by: Erik Grinaker <[email protected]> # Conflicts: # pkg/kv/kvserver/rangefeed/BUILD.bazel # pkg/kv/kvserver/rangefeed/bench_test.go # pkg/kv/kvserver/rangefeed/processor.go # pkg/kv/kvserver/rangefeed/processor_helpers_test.go # pkg/kv/kvserver/rangefeed/processor_test.go # pkg/kv/kvserver/replica_rangefeed.go
wenyihu6 · Oct 23, 2024 · 23fd996 · 23fd996
1 parent 3e17a3e
commit 23fd996
Show file tree

Hide file tree

Showing 10 changed files with 1,782 additions and 2,462 deletions.
diff --git a/pkg/kv/kvclient/rangefeed/rangefeed_external_test.go b/pkg/kv/kvclient/rangefeed/rangefeed_external_test.go
diff --git a/pkg/kv/kvserver/BUILD.bazel b/pkg/kv/kvserver/BUILD.bazel
@@ -397,7 +397,6 @@ go_test(
         "//pkg/kv",
         "//pkg/kv/kvclient",
         "//pkg/kv/kvclient/kvcoord",
-        "//pkg/kv/kvclient/rangefeed",
         "//pkg/kv/kvclient/rangefeed/rangefeedcache",
         "//pkg/kv/kvpb",
         "//pkg/kv/kvserver/abortspan",

diff --git a/pkg/kv/kvserver/rangefeed/BUILD.bazel b/pkg/kv/kvserver/rangefeed/BUILD.bazel
@@ -21,7 +21,6 @@ go_library(
         "stream_manager.go",
         "task.go",
         "test_helpers.go",
-        "testutil.go",
         "unbuffered_registration.go",
         "unbuffered_sender.go",
     ],