rangefeed: unconditionally use rangefeed scheduler #114410

erikgrinaker · 2023-11-14T11:22:12Z

kvserver: enable rangefeed scheduler by default

Touches #113029.
Epic: none
Release note (performance improvement): rangefeeds, the infrastructure used for changefeeds, now use a more efficient engine that reduces the number of goroutines and the associated Go scheduler pressure and latency.

rangefeed: unconditionally use rangefeed scheduler

This patch unconditionally uses the new rangefeed scheduler. This has no mixed-version concerns, since the scheduler is internal to each node and uses the same client protocol.

Epic: none
Release note (ops change): the setting kv.rangefeed.scheduler.enabled has been removed, as the rangefeed scheduler is now unconditionally enabled.

rangefeed: remove LegacyProcessor

The rangefeed scheduler is now used unconditionally.

rangefeed: remove Config.PushTxnsInterval

This has no effect for scheduler-based processors, which is now the only processor type. Instead, the RangeFeedPushTxnsInterval testing knob is now propagated to the store's rangefeed txn pusher loop.

blathers-crl · 2023-11-14T11:22:16Z

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

cockroach-teamcity · 2023-11-14T11:22:27Z

This change is

miretskiy

Reviewed 9 of 12 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker)

pkg/kv/kvserver/rangefeed/processor_test.go line 333 at r2 (raw file):

	sch := NewScheduler(SchedulerConfig{
		Workers:         1,

do we have tests that spin use multiple workers?
Does it make sense to just throw some metamorphic constant here and for the priority workers below?

miretskiy · 2023-12-12T16:27:26Z

@erikgrinaker -- what's left for this PR? (other than CI)?
You might need to change mixed_version_cdc.go

erikgrinaker · 2023-12-13T09:53:53Z

Nothing really, just wanted to wait for 23.2 to firm up a bit first, to make it easier to backport fixes.

I'll address your comments and merge this when I have time.

erikgrinaker

You might need to change mixed_version_cdc.go

Thanks, done.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker and @miretskiy)

pkg/kv/kvserver/rangefeed/processor_test.go line 333 at r2 (raw file):

Previously, miretskiy (Yevgeniy Miretskiy) wrote…

do we have tests that spin use multiple workers?
Does it make sense to just throw some metamorphic constant here and for the priority workers below?

It won't make any difference here. There's only a single range, which can only be processed by a single worker at a time by definition. Multiple workers are only relevant with multiple ranges, and these are covered by integration and end-to-end tests.

Epic: none Release note (performance improvement): rangefeeds, the infrastructure used for changefeeds, now use a more efficient engine that reduces the number of goroutines and the associated Go scheduler pressure and latency.

This patch unconditionally uses the new rangefeed scheduler. This has no mixed-version concerns, since the scheduler is internal to each node and uses the same client protocol. Epic: none Release note (ops change): the setting `kv.rangefeed.scheduler.enabled` has been removed, as the rangefeed scheduler is now unconditionally enabled.

The rangefeed scheduler is now used unconditionally. Epic: none Release note: None

This has no effect for scheduler-based processors, which is now the only processor type. Instead, the `RangeFeedPushTxnsInterval` testing knob is now propagated to the store's rangefeed txn pusher loop. Epic: none Release note: None

erikgrinaker · 2024-01-03T10:41:36Z

bors r+

craig · 2024-01-03T11:37:55Z

Build succeeded:

Bazel Essential CI (Cockroach)

121138: storage,ingest: enable ingestion optimization using flushableIngest r=aadityasondhi a=aadityasondhi In cockroachdb/pebble#3398, we introduced an optimization in pebble where we could use flushableIngests with excises for ingesting SSTs with RangeDels and RangeKeyDels. This patch turns this optimization on using `sstContainsExciseTombstone`. Informs cockroachdb/pebble#3335. Release note: None 121164: Revert "rangefeed: unconditionally use rangefeed scheduler" r=erikgrinaker a=erikgrinaker This reverts 3/4 commits from #114410, only leaving 1dbdbe9 which enabled the scheduler by default. There was significant code drift in tests, but I think I've been able to address the conflicts. This revert does not integrate with the changes from #120347, so the legacy rangefeed processor will not use the improved memory accounting. We still shouldn't leak budget allocations, since the processor implementations are entirely independent, but it's worth having a second look to make sure the registry (which is used by both processors) don't make assumptions about this. Touches #121054. Epic: none. Release note: the following release note from #114410 should be reverted/ignored: "the setting kv.rangefeed.scheduler.enabled has been removed, as the rangefeed scheduler is now unconditionally enabled". 121212: security: wrap error when parsing DN r=rafiss a=rafiss Epic: CRDB-34126 Release note: None Co-authored-by: Aaditya Sondhi <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>

The ScheduledProcessor has been in default use since 24.1, substantially out performs the LegacyProcessor, and is the likely place that new improvements will be implemented. Here, we remove the LegacyProcessor, retiring the associated cluster setting. This is similar to cockroachdb#114410, but reconstructed from scratch. Epic: none Release note (ops change): The setting kv.rangefeed.scheduler.enabled has been retired. The rangefeed scheduler is now unconditionally enabled. Co-authored-by: Erik Grinaker <[email protected]>

The ScheduledProcessor has been in default use since 24.1, substantially out performs the LegacyProcessor, and is the likely place that new improvements will be implemented. Here, we remove the LegacyProcessor, retiring the associated cluster setting. This is similar to cockroachdb#114410, but reconstructed from scratch. Epic: none Release note (ops change): The setting kv.rangefeed.scheduler.enabled has been retired. The rangefeed scheduler is now unconditionally enabled. Co-authored-by: Erik Grinaker <[email protected]> # Conflicts: # pkg/kv/kvserver/rangefeed/BUILD.bazel # pkg/kv/kvserver/rangefeed/bench_test.go # pkg/kv/kvserver/rangefeed/processor.go # pkg/kv/kvserver/rangefeed/processor_helpers_test.go # pkg/kv/kvserver/rangefeed/processor_test.go # pkg/kv/kvserver/replica_rangefeed.go

The ScheduledProcessor has been in default use since 24.1, substantially out performs the LegacyProcessor, and is the likely place that new improvements will be implemented. Here, we remove the LegacyProcessor, retiring the associated cluster setting. This is similar to cockroachdb#114410, but reconstructed from scratch. Epic: none Release note (ops change): The setting kv.rangefeed.scheduler.enabled has been retired. The rangefeed scheduler is now unconditionally enabled. Co-authored-by: Erik Grinaker <[email protected]>

132825: rangefeed: remove LegacyProcessor r=wenyihu6 a=stevendanna The ScheduledProcessor has been in default use since 24.1, substantially out performs the LegacyProcessor, and is the likely place that new improvements will be implemented. Here, we remove the LegacyProcessor, retiring the associated cluster setting. This is similar to #114410, but reconstructed from scratch. Epic: none Release note (ops change): The setting kv.rangefeed.scheduler.enabled has been retired. The rangefeed scheduler is now unconditionally enabled. Co-authored-by: Steven Danna <[email protected]>

erikgrinaker requested a review from miretskiy November 14, 2023 11:22

erikgrinaker self-assigned this Nov 14, 2023

erikgrinaker requested a review from a team as a code owner November 14, 2023 11:22

erikgrinaker requested a review from a team November 14, 2023 11:22

erikgrinaker requested a review from a team as a code owner November 14, 2023 11:22

erikgrinaker requested review from herkolategan and DarrylWong and removed request for a team November 14, 2023 11:22

erikgrinaker removed request for herkolategan and DarrylWong November 14, 2023 11:23

erikgrinaker force-pushed the rangefeed-scheduler-default branch from 22bc8cb to 7e8809b Compare November 14, 2023 11:26

miretskiy approved these changes Nov 14, 2023

View reviewed changes

erikgrinaker requested a review from miretskiy January 2, 2024 16:23

erikgrinaker force-pushed the rangefeed-scheduler-default branch from 7e8809b to 2cfd5f9 Compare January 2, 2024 16:23

erikgrinaker commented Jan 2, 2024

View reviewed changes

erikgrinaker force-pushed the rangefeed-scheduler-default branch 2 times, most recently from 5efb944 to 941af2e Compare January 2, 2024 17:25

kvserver: enable rangefeed scheduler by default

1dbdbe9

Epic: none Release note (performance improvement): rangefeeds, the infrastructure used for changefeeds, now use a more efficient engine that reduces the number of goroutines and the associated Go scheduler pressure and latency.

erikgrinaker force-pushed the rangefeed-scheduler-default branch from 941af2e to 4075e88 Compare January 3, 2024 09:12

erikgrinaker added 3 commits January 3, 2024 09:49

rangefeed: remove LegacyProcessor

a2f915a

The rangefeed scheduler is now used unconditionally. Epic: none Release note: None

rangefeed: remove Config.PushTxnsInterval

9e97770

This has no effect for scheduler-based processors, which is now the only processor type. Instead, the `RangeFeedPushTxnsInterval` testing knob is now propagated to the store's rangefeed txn pusher loop. Epic: none Release note: None

erikgrinaker force-pushed the rangefeed-scheduler-default branch from 4075e88 to 9e97770 Compare January 3, 2024 09:50

craig bot merged commit d62272f into cockroachdb:master Jan 3, 2024
7 of 9 checks passed

erikgrinaker mentioned this pull request Jan 3, 2024

rangefeed: enable mux and scheduler by default #113029

Closed

kathancox mentioned this pull request Jan 11, 2024

changefeedccl: enhance "advanced-changefeed-configuration" doc #114157

Closed

This was referenced Mar 25, 2024

rangefeed: revert removal of non-mux/scheduler rangefeeds #121054

Closed

Revert "rangefeed: unconditionally use rangefeed scheduler" #121164

Merged

stevendanna mentioned this pull request Oct 17, 2024

rangefeed: remove LegacyProcessor #132825

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rangefeed: unconditionally use rangefeed scheduler #114410

rangefeed: unconditionally use rangefeed scheduler #114410

erikgrinaker commented Nov 14, 2023

blathers-crl bot commented Nov 14, 2023

cockroach-teamcity commented Nov 14, 2023

miretskiy left a comment

miretskiy commented Dec 12, 2023

erikgrinaker commented Dec 13, 2023

erikgrinaker left a comment

erikgrinaker commented Jan 3, 2024

craig bot commented Jan 3, 2024

rangefeed: unconditionally use rangefeed scheduler #114410

rangefeed: unconditionally use rangefeed scheduler #114410

Conversation

erikgrinaker commented Nov 14, 2023

blathers-crl bot commented Nov 14, 2023

cockroach-teamcity commented Nov 14, 2023

miretskiy left a comment

Choose a reason for hiding this comment

miretskiy commented Dec 12, 2023

erikgrinaker commented Dec 13, 2023

erikgrinaker left a comment

Choose a reason for hiding this comment

erikgrinaker commented Jan 3, 2024

craig bot commented Jan 3, 2024