Skip to content

Commit

Permalink
[bugfix] dedup groupby columns in Deck visualizations (apache#4801)
Browse files Browse the repository at this point in the history
When specifying the same column twice as a `Extra Data for JS` and
`Categorical Color`, an error is issued. This addresses this issue.
  • Loading branch information
mistercrunch authored Apr 11, 2018
1 parent d73a7f1 commit da98abe
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions superset/viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,7 @@ def query_obj(self):
if fd.get('js_columns'):
gb += fd.get('js_columns')
metrics = self.get_metrics()
gb = list(set(gb))
if metrics:
d['groupby'] = gb
d['metrics'] = self.get_metrics()
Expand Down

0 comments on commit da98abe

Please sign in to comment.