[bugfix] dedup groupby columns in Deck visualizations #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue.
Codecov Report
@@ Coverage Diff @@
## master #4801 +/- ##
==========================================
+ Coverage 72.33% 72.34% +<.01%
==========================================
Files 208 208
Lines 15516 15517 +1
Branches 1201 1201
==========================================
+ Hits 11224 11225 +1
Misses 4289 4289
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Apr 11, 2018
|
Didn't want to risk it, the set and list api are not the exact same, not sure if we handle the conversion on |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue.
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying the same column twice as a
Extra Data for JSandCategorical Color, an error is issued. This addresses this issue.