Add a dependency on jna 5.7 to provide a mac compatible version #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously we excluded the transitive JNA dependency (#237) as it is not required where we are using a JDK, however our deployed container images use a JRE only to reduce the container footprint, this doesn't work where the JNA dependency is excluded and causes runtime errors (as indicated in the elastic-apm docs).
This is in service of being able to run our Scala apps locally more easily in general in order to better test and debug their behaviour (this is a blocker to doing that).
See wellcomecollection/catalogue-api#743 for the offending PR and error.
How to test
publishLocal
thetypesafe_app
library, and attempt to run a dependent app in a JRE only environment e.g../builds/run_sbt_task_in_docker.sh "project items" "run"
in https://github.com/wellcomecollection/catalogue-api.How can we measure success?
Can we:
Have we considered potential risks?
We are using a version of JNA not explicitly compatible with the elastic apm agent, that may cause other unexpected issues.