Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependency on jna 5.7 to provide a mac compatible version #238

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Jan 24, 2024

What does this change?

Previously we excluded the transitive JNA dependency (#237) as it is not required where we are using a JDK, however our deployed container images use a JRE only to reduce the container footprint, this doesn't work where the JNA dependency is excluded and causes runtime errors (as indicated in the elastic-apm docs).

This is in service of being able to run our Scala apps locally more easily in general in order to better test and debug their behaviour (this is a blocker to doing that).

See wellcomecollection/catalogue-api#743 for the offending PR and error.

How to test

How can we measure success?

Can we:

  • Run consumers locally without this error
  • Run consumers in production / staging with a JRE

Have we considered potential risks?

We are using a version of JNA not explicitly compatible with the elastic apm agent, that may cause other unexpected issues.

Previously we excldued the transitive jna dependency as it is not required where we are using a jdk, however our deployed container images use a jre only to reduce the container footprint, this doesn't work where the jna dep is excluded and causes runtime errors.
@kenoir kenoir requested a review from a team January 24, 2024 12:48
@kenoir kenoir merged commit f8ef7fa into main Jan 24, 2024
1 check passed
@kenoir kenoir deleted the rk/add-jna-with-explicit-version branch January 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants