Exclude transitive dependency on pre 5.7 version of JNA #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Follows #236, and required for the same reason. We are still pulling in an old version of the JNA library causing this issue (pre 5.7), see:
We exclude the JNA lib as a transitive dep, which avoids packaging it and blowing up downstream consumers.
https://github.com/elastic/apm-agent-java/blob/be8add66d074febe16748691725b6cfe69f238d0/docs/setup-attach-api.asciidoc
Using
publishLocal
to try this out locally before release and running a project that incorporates this dependency where we've seen this issue, the runtime error is fixed and we can see the dependency excluded.Resolves this issue: wellcomecollection/catalogue-api#737 (comment)
See the dep being excluded (jna-platform is still there, but jna is excluded).
How to test
How can we measure success?
Developers can run projects locally on their machines without issue.
Have we considered potential risks?
It's possible we hit one of the special conditions described in the caveats. We'll see this if consumers fail!