Add a diagram showing what the request flow looks like #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
force-pushed
the
items-apis-documentation
branch
from
252ea87 to
6e52a35
Compare
paul-butcher
reviewed
Jun 8, 2022
* add genre concept ids to image filters * Apply auto-formatting rules * update test docs * update test docs * add works filter test * new test docs * genre concept id filter on works * add genre concept ids to image filters * Apply auto-formatting rules * use new availability data in aggregation test * update images includes tests * update availabilities test data * update test for new data * update test for new data * update test for new data * remove .id from genre concept filters --------- Co-authored-by: Buildkite on behalf of Wellcome Collection <[email protected]>
…odule Use the new Terraform module to create ACM certificates
rank tests for articles, exhibitions, and events
* first stab * annotate on nano * Apply auto-formatting rules * try without the colours * term wrapping * annotation styling * annotation styling * double dollar * put it in the right pipeline * add artifact path --------- Co-authored-by: Buildkite on behalf of Wellcome Collection <[email protected]>
Change the way we handle the lookup of unhandled items
…oduction-dates Add filtering and sorting by production date on images
…-changed-work-id update the rank tests to use a changed work id
corrected [search_docs] and [snapshots] URLs
Remove references to _queryType
…2.25.0 Bump scala-libs to v32.25.0
…2.26.0 Bump scala-libs to v32.26.0
This change follows #736, and adds an HTTP healthcheck to the items API to ensure the scala service has started before it is registered healthy at the NLB and starts serving requests.
…dpoint-items Adds a simple healthcheck endpoint for the items service
Add default code owners
This change adds a healthcheck endpoint to provide to a loadbalancer for the purposes of checking application health at deployment and under normal service.
…dpoint-requests Adds a simple healthcheck endpoint for the requests service
Co-authored-by: Paul Butcher <[email protected]>
## What is this change? This change allows reviews from all developers to be sufficient for terraform changes. At present an approval to merge a PR for a terraform change must come from someone in the developers group, we probably want to widen that. ## How to test? Merge it and see if developers outside the scala-reviewers group can approve terraform changes.
…terraform Add @wellcomecollection/developers to /terraform folder in CODEOWNERS
Mermaid on Github doesn't like it when an arrow is unlabelled in a sequence diagram, even when it's just a response to the previous message in the opposite direction. I have added an "OK" to each of these and turned them all into dashed arrows to signify they are responses.
jamieparkinson
approved these changes
Feb 5, 2024
Co-authored-by: Paul Butcher <[email protected]>
Mermaid on Github doesn't like it when an arrow is unlabelled in a sequence diagram, even when it's just a response to the previous message in the opposite direction. I have added an "OK" to each of these and turned them all into dashed arrows to signify they are responses.
…tems-apis-documentation
|
@alexwlchan have we just rebased over each other? 😬 |
|
@jamieparkinson That seems unlikely, given I haven't touched this repo in months! I am still getting the odd GitHub notification for issues/PRs that I opened and haven't unsubscribed from yet, but I'm not pushing code (and don't think I should be able to?!). Whatever mess is going on here is somebody else's fault 😜 And I'm not actually requesting a review 👻 but I guess GitHub is telling you I am because I "own" the pull request? Very spooky! [Confirmed, GitHub blocks me from pushing new branches!] |
|
Aha - I've caused my own issues then! Very odd, anyway, as you were! |
|
*retreats back into fog and darkness* |
|
But yay for finally getting this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struggling to hold these interactions in my head, so I drew a quick diagram. This is also a place to hang any information about short-circuiting logic if it's useful; but for now it's just a diagram.
Rendered version: https://github.com/wellcomecollection/catalogue-api/blob/items-apis-documentation/docs/requesting_flow.md