Adds a simple healthcheck endpoint for the requests service #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
changed the title
This was referenced Jan 25, 2024
13 tasks
2 tasks
kenoir
force-pushed
the
rk/add-healthcheck-endpoint-requests
branch
from
4d3db3b to
c137f3f
Compare
rcantin-w
approved these changes
Jan 26, 2024
This change adds a healthcheck endpoint to provide to a loadbalancer for the purposes of checking application health at deployment and under normal service.
kenoir
force-pushed
the
rk/add-healthcheck-endpoint-requests
branch
from
c939911 to
a06ba85
Compare
| return asyncHandler(async (req, res) => { | ||
| res.status(200).json({ | ||
| status: "ok", | ||
| config, |
There was a problem hiding this comment.
When I saw this, I was slightly concerned that it might be a vector for leaking secrets.
It isn't, but is there a risk that someone might unwittingly expose something in the future by adding it to the config?
paul-butcher
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change follows #739, and adds an HTTP healthcheck to the requests API to ensure the Scala service has started before it is registered healthy at the NLB and starts serving requests.
A further change will need to be made in the wellcomecollection/identity respository to have the identity infrastructure pay attention to the new endpoint.
The required change will be similar to the one in this repository to add a HTTP healthcheck.
See wellcomecollection/identity#398
How to test?
How can we measure success?
No downtime during deployments resulting in a better experience for visitors to the site, and fewer errors that we cannot effectively respond to in the alerts channel.