Fix: Increase height of 'About' window

[akaustav]

What is the purpose of this pull request?

• Bug fix

What changes did you make?
Increased the height of the About WebTorrent window which shows when you click Help > About WebTorrent.

Which issue (if any) does this pull request address?
#1736

Is there anything you'd like reviewers to focus on?

• Tested in Windows 10 (64 bit) only.
• Need help testing in other supported platforms.
• Need instructions/help to update unit tests, and/or end-to-end tests.

Screenshot

[mathiasvr]

This about window is only used on Windows and Linux, on macOS the native about role is used instead, and looks like this:

I see the Copyright notice is missing for the other platforms, it would be great if you could add it as well @akaustav.

Edit: Just noticed we already had the copyright notice, but there was an error in the path, so took the liberty to fix it on your branch.

[akaustav]

Cool, thanks @mathiasvr. I confirm that the copyright information is available in the window now. However, 220 height was not sufficient to display the copyright line. So, I had to increase the height even further. After changing the height to 250, it looks like this in Windows 10:

[akaustav]

Also, I see that the lines related to Help menu in Windows and Linux:

webtorrent-desktop/src/main/menu.js

Lines 441 to 450 in 0198d74

	// Help menu (Windows, Linux)
	template[5].submenu.push(
	{
	type: 'separator'
	},
	{
	label: 'About ' + config.APP_NAME,
	click: () => windows.about.init()
	}
	)

Also, like @mathiasvr said, here is the code snippet for Mac (Darwin):

webtorrent-desktop/src/main/menu.js

Lines 340 to 347 in 0198d74

	if (process.platform === 'darwin') {
	// WebTorrent menu (Mac)
	template.unshift({
	label: config.APP_NAME,
	submenu: [
	{
	role: 'about'
	},

However, I fail to understand what controls the height of the about dialog in macOS. Does macOS automatically adjust the window width and height to accommodate the contents? Or is there a setting in a configuration file somewhere?

Also, would you think it is a good idea to keep the dimensions of the About window/dialog box consistent across multiple platforms?

[mathiasvr]

@akaustav On mac the about window is populated with info from the packaging process, and I believe you are correct that the dimensions are automatically adjusted.

I think dimensions should be the same across platforms, but it's more important to have a consistent look.
I tried displaying the Windows/Linux about window on mac and I get this:

It's weird that there is such a big difference between macOS and Windows? However, as long as it looks good in Windows and Linux it's fine since we don't use this window on mac.

[hicom150]

This fix looks great, but I found two small issues 😅

• Copyright path should point to build instead of src otherwise it will not be correctly loaded after packing
• After upgrading master electron to electron@7 there is a small issue to remove the window menu BrowserWindow removeMenu method not working on v7.1.1 electron/electron#21088 so a I used a small hack 😉

I will add this corrections in the following commit 👍

[hicom150]

Good work @akaustav and @mathiasvr 🎉

[mathiasvr]

Thanks @hicom150, nice catches 👍