About WebTorrent shows half window

[akaustav]

What version of WebTorrent Desktop are you using?
0.21.0

What operating system and version?
Windows 10

What happened?
When I click on Help > About WebTorrent, I see a window which seems to display only the top half of the content. So, I can only see the application icon, but not the text (name, version number, etc) - like this:

What did you expect to happen?
To view the full information about the application. Similar to what was showing until the previous version v0.20.0.

Are you willing to submit a pull request to fix this bug?
Not sure. I am a novice in Electron. However, it was fine in the previous version v0.20.0. I can try tracing the change log to find which commit(s) might have caused this.

[akaustav]

Here is a log of what I have found so far:

• Compared commits between 0.20.0 and 0.21.0 tags.
• From electron documentation, it looks like a window's height is controlled by the optional height property.
• The height property of the 'About' window is set at 170.
  

  webtorrent-desktop/src/main/windows/about.js

  Line 18 in d778374

  height: 170,

• That property has not changed since 2016-05-27
  https://github.com/webtorrent/webtorrent-desktop/blame/d7783749ca155e196cd5edbb5fae9f8c83414945/src/main/windows/about.js#L18
• Noticed that [email protected] was using [email protected]:
  

  webtorrent-desktop/package.json

  Line 57 in fbb3fa6

  "electron": "1.6.16",

• And [email protected] is using electron@~6.0.9:
  

  webtorrent-desktop/package.json

  Line 56 in d778374

  "electron": "~6.0.9",

• I was able to reproduce this issue by running the app on my local Windows machine using latest (as of 2019-10-29) code in the master branch.
• I am attributing this bug to be one of the breaking changes during the electron upgrade.
• I am not sure how to check the documentation for [email protected].
• Tried setting the height property to a number greater than 170 like 220. And it seems to make the window tall enough to display the full contents.
• At the moment, I do not have access to a machine running Linux or macOS. So, I am not sure if this is even an issue in those platforms. And if changing the height property breaks something in those platforms.
• For now, I have raised PR Fix: Increase height of 'About' window #1737 changing the height property to 220.

[SikoSoft]

I experience the same thing, Windows 10 as well. No idea what version of WebTorrent I have since I can't see the information in the window, which is why I clicked it to begin with.

[akaustav]

@SikoSoft I am thinking you have version 0.21.0. Here is the the hard way to find the information:

1. Open WebTorrent.
2. Go to Help > About WebTorrent.
3. Selecting all contents of the window, by pressing the Ctrl + A key combination.
4. Copy the selected contents to the clipboard, by pressing Ctrl + C.
5. Paste the clipboard contents on any text editor by pressing Ctrl + V.

[hicom150]

Fixed! 🎉