Replace nobin-debian-installer
#1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hicom150
force-pushed
the
replace_nobin_debian_installer
branch
from
3fdb037 to
aff402f
Compare
feross
requested changes
Sep 10, 2019
This was referenced Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Replace
nobin-debian-installerwithelectron-installer-debian.This change has some implications:
desktop-fileandiconinstallation get simplified aselectron-installer-debiantakes the responsibility to install it correctly. 👍electron-installer-debianhandles binary installation and permissions correctly. 👍/usr/libby default as it is explained hereIn addition, along with
electron-installer-debianthere are another installer flavors that could help to reach new distributions:and some more...
Maybe it is worth to give it a try 😉
Is there anything you'd like reviewers to focus on?
Although I test this changes carefully in Ubuntu 18.04.3 LTS every check or suggestion is more than welcome 😊