Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing nobin-debian-installer #1676

Closed
feross opened this issue Sep 6, 2019 · 5 comments
Closed

Consider replacing nobin-debian-installer #1676

feross opened this issue Sep 6, 2019 · 5 comments

Comments

@feross
Copy link
Member

feross commented Sep 6, 2019

nobin-debian-installer seems abandoned by @grunjol. So I made a fork here (https://github.com/webtorrent/nobin-debian-installer) with the following fixes:

If @grunjol doesn't respond soon, we should probably replace this package with an alternative so we don't have to maintain our own fork.

@hicom150
Copy link
Contributor

hicom150 commented Sep 9, 2019

#1682 is a PR to try to replace nobin-debian-installer with electron-installer-debian.

Hope that it would help to make a step forward for more linux distribution support 😉

@grunjol
Copy link
Contributor

grunjol commented Sep 9, 2019

Hi there!
I just checked your mention.
For some reason I didn't get the PRs notification. I will be glad to merge them and make a release this week.

Regarding the electron-installer-debian, is the package cross-platform? or is *nix only?

@feross
Copy link
Member Author

feross commented Sep 10, 2019

Thanks for responding @grunjol. What do you think of @hicom150's PR? It seems useful to be able to just add in other electron-installer-* packages following the same style and get support for more platforms, I think.

@hicom150
Copy link
Contributor

I will be glad to merge them and make a release this week.

That would be awesome! 👍

Regarding the electron-installer-debian, is the package cross-platform? or is *nix only?

As far as it says in the documentation this seems to support OSX and Linux.

@feross
Copy link
Member Author

feross commented Sep 15, 2019

Yep, it worked on macOS for me. Since this is merged now and we can rely on the electron community to maintain it for us in the future, I think it was right call. Closing this now.

@feross feross closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants