Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopped crawls should not show stop/cancel buttons #2101

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Stopped crawls should not show stop/cancel buttons #2101

merged 2 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. ui: fix stopped crawls still showing stop/cancel buttons: 

    - crawler isActive() should only look at running states, not 'stopping', since stopping may not be reset to false
after crawl is stopped. crawl is guaranteed to remain in one of the active states while stopping on the backend
    @ikreymer
    ikreymer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ef9263d View commit details
    Browse the repository at this point in the history

  2. refactor from review

    @ikreymer
    ikreymer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5b080a6 View commit details
    Browse the repository at this point in the history