Stopped crawls should not show stop/cancel buttons

[ikreymer]

• crawler isActive() should only look at running states, not 'stopping', since stopping may not be reset to false after crawl is stopped (probably should reset, but also a record that the crawl ended as being stopped). crawl is guaranteed to remain in one of the active states while stopping on the backend
• fixes [Bug]: Stopped crawls still showing stop/cancel button #2100

Testing:

• Check a stopped crawl, confirm stop/cancel buttons no longer show up.

[emma-sg]

This could be simplified a little:

export function isActive({ state }: Partial<Crawl | QARun>) {
  return (activeCrawlStates as readonly (typeof state)[]).includes(state);
}

Array.prototype.includes can be passed undefined as an argument, and will correctly return false if the array doesn't contain an undefined, which it doesn't in this case.

[ikreymer]

Thanks, updated!