Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Watch tab crawl state consistency #2060

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Aug 30, 2024

Fixes #2059

Changes

  • Fixes empty watch tab during some active states
  • Disables exclusion and browser window editing while a crawl is stopping
  • Refactors frontend crawl states to match backend

Manual testing

Verify with repro steps in #2059

The following should be true:

  • Browser Window editing is enabled when a crawl is in any active state that is not stopping
  • Exclusions editing and screencast is enabled only when a crawl is in a running state

@SuaYoo SuaYoo force-pushed the issue-2048-num-browsers--fix-watch-crawl branch from b0d25e7 to 8fa0e29 Compare August 30, 2024 21:48
@SuaYoo SuaYoo marked this pull request as ready for review August 30, 2024 21:51
Base automatically changed from issue-2048-num-browsers to main September 6, 2024 00:32
@SuaYoo SuaYoo force-pushed the issue-2048-num-browsers--fix-watch-crawl branch from 8fa0e29 to 6539d86 Compare September 9, 2024 17:45
@ikreymer
Copy link
Member

ikreymer commented Sep 9, 2024

Browser Window editing is enabled when a crawl is in any active state that is not stopping

When a crawl is starting, it was enabled in the menu but the button was disabled, though menu item didn't do anything. I think it should be enabled for starting as well in this case.. I think we can have it be enabled for any state in RUNNING_AND_WAITING_STATES though in some of these it won't have an effect until later, but should be possible to change I think. Users might want to scale down if crawl is waiting for capacity (though it'll still start even if desired scale can't be attained)

@SuaYoo
Copy link
Member Author

SuaYoo commented Sep 10, 2024

When a crawl is starting, it was enabled in the menu but the button was disabled, though menu item didn't do anything. I think it should be enabled for starting as well in this case..

What states are included in isCrawlRunning? That's what the button currently checks. I also see that it's enabled for starting, could you provide more repro steps?

Screenshot 2024-09-10 at 12 30 15 PM

@SuaYoo SuaYoo force-pushed the issue-2048-num-browsers--fix-watch-crawl branch from 6539d86 to 228d170 Compare September 10, 2024 19:31
@SuaYoo SuaYoo force-pushed the issue-2048-num-browsers--fix-watch-crawl branch from 228d170 to 9c52d9e Compare September 10, 2024 21:35
@ikreymer
Copy link
Member

What states are included in isCrawlRunning? That's what the button currently checks. I also see that it's enabled for starting, could you provide more repro steps?

Yep, seems to be working now and the other issue also resolved, maybe was running an older version. Looks good!

@SuaYoo SuaYoo merged commit 55f3b8a into main Sep 10, 2024
2 checks passed
@SuaYoo SuaYoo deleted the issue-2048-num-browsers--fix-watch-crawl branch September 10, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Running crawl states are inconsistent in "Watch Crawl"
2 participants