Fix regression re. isIncludeEntryExports → skipExportsAnalysis from s…

…cripts/plugins (resolves #857)
webpro-nl · Nov 26, 2024 · b8379de · b8379de
1 parent 6e62de8
commit b8379de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/knip/src/index.ts b/packages/knip/src/index.ts
@@ -211,7 +211,7 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {
         const ws =
           (dependency.containingFilePath && chief.findWorkspaceByFilePath(dependency.containingFilePath)) || workspace;
         const specifierFilePath = getReferencedInternalFilePath(dependency, ws);
-        if (specifierFilePath) principal.addEntryPath(specifierFilePath);
+        if (specifierFilePath) principal.addEntryPath(specifierFilePath, { skipExportsAnalysis: true });
       }
     }
 

diff --git a/packages/knip/test/include-entry-exports-scripts.test.ts b/packages/knip/test/include-entry-exports-scripts.test.ts
@@ -21,7 +21,7 @@ test('Skip unused exports in entry source files and scripts', async () => {
   });
 });
 
-test('Report unused exports in source files and scripts (skip for plugin entry files)', async () => {
+test('Report unused exports in source files (skip for scripts and plugin entry files)', async () => {
   const { counters } = await main({
     ...baseArguments,
     cwd,
@@ -30,7 +30,7 @@ test('Report unused exports in source files and scripts (skip for plugin entry f
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    exports: 5,
+    exports: 0, // skip for scripts and plugin entry files
     processed: 5,
     total: 5,
   });