Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 Jest configured setup scripts reporting as unused exports when --include-entry-exports is enabled #857

Closed
4 tasks done
stfstoris opened this issue Nov 26, 2024 · 4 comments
Labels
regression Something is no longer working

Comments

@stfstoris
Copy link

Prerequisites

Reproduction url

https://github.com/stfstoris/knip-jest-setup-issue

Reproduction access

  • I've made sure the reproduction is publicly accessible

Good version

5.33.3

Bad version

5.34.0

Description of the regression

Reproduction of issue: https://github.com/stfstoris/knip-jest-setup-issue

There seems to be a regression of an issue my colleague @shawnmcknight logged a while back: #716, where after we updated knip to latest we are now getting unused export errors from our jest setup and teardown files with --include-entry-exports enabled:

image

Running this on any version after original fix version (5.24.2) and before version 5.34.0 does not give us this error, so it appears that this version introduced regression:

image

@stfstoris stfstoris added the regression Something is no longer working label Nov 26, 2024
@webpro webpro closed this as completed in b8379de Nov 26, 2024
@webpro
Copy link
Collaborator

webpro commented Nov 26, 2024

Thanks the report, @stfstoris! Did a major refactoring around that version and I've missed something indeed. Should be sorted in the next.

@webpro
Copy link
Collaborator

webpro commented Nov 26, 2024

🚀 This issue has been resolved in v5.38.1. See Release 5.38.1 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@stfstoris
Copy link
Author

@webpro thank you for the quick fix!

@webpro
Copy link
Collaborator

webpro commented Nov 26, 2024

🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something is no longer working
Projects
None yet
Development

No branches or pull requests

2 participants