Clarify Rule documentation and fix broken links #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explanation of mutually exclusive `Rule` options (either supply a `resource` or supply `test`|`exclude`|`include`) - Fix broken links to `Rule.resource` documentation
|
Just after hitting submit I noticed the guidelines in the contributing doc about the conventional commits format. I'm happy to resubmit in the proper format. |
|
@dylanonelson no worries, we can squash and merge once reviewed. I'm working on the terminated CI error right now btw. |
skipjack
approved these changes
Aug 29, 2017
|
Thanks @dylanonelson! If you do submit other PRs, it would be great if you could follow the conventional commits spec as you mentioned. |
|
Will do, thanks! I'm excited to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruleoptions (either supply aresourceor supplytest|exclude|include)Rule.resourcedocumentation