-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guides - Tree Shaking and Production Rewrites #1508
Conversation
Ok I'm still working on this a little (e.g. some links and examples are missing) but for the most part the outline of these is pretty much good to go in my mind. @TheDutchCoder @jakearchibald if either of you have some time to review and let me know your thoughts I'd appreciate it. Also anyone whose contributed to this guide in the past... @henriquea, @rajagopal4890, @markerikson, @simon04, @kisnows, @chrisVillanueva, @swapnilmishra, @bring2dip, @redian, @xgqfrms Please feel free to review as well. My goal is not to blow away any previous work, just to synchronize the guide with our others (#1258) and make it a bit more approachable. @sokra I put a little TODO about the The way I broke this down I think should make it easy to add small targeted sections on each configuration change recommended for production. For example, if the |
I'm going to work on resolving the last couple |
I've copied the older content to separate files locally so I could start outlining the structure of the updated guide. I will slowly integrate various parts back in as this gets more fleshed out.
Adding this is never even mentioned, I think it was just copied over by accident. It's covered in detail in the hot-module-replacement guide which comes immediately after this one. cc @TheDutchCoder
257bce1
to
81672d0
Compare
Add tree shaking example that corresponds with: webpack/webpack.js.org#1508
Add example for the production guide that corresponds to: webpack/webpack.js.org#1508
Opened the following example PRs and populated the missing content:
I'm going to merge but still interested in feedback if anyone has ideas. @sokra I removed this
|
a87640d
to
ed1bc15
Compare
Ok I ran the build/tests locally and everything passed. I'm going to give this one last chance to pass on travis before merging. The @sokra @bebraw @Munter initially I thought it was a |
Actually, I watched the last build when it hit the end and it does hang on |
Add tree shaking example that corresponds with: webpack/webpack.js.org#1508
Add example for the production guide that corresponds to: webpack/webpack.js.org#1508
This continues our work #1258 and resolves most of the issues mentioned in #1331. It is a WIP though, we still need to populate the
TODO
code blocks and I'm currently working on updating theProduction guide which may take a bit longer.
Resolves #1331
Related #1258
cc @jakearchibald