Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ipv6 [::] #676

Merged
merged 2 commits into from
Oct 28, 2016
Merged

Fixed ipv6 [::] #676

merged 2 commits into from
Oct 28, 2016

Conversation

NewFuture
Copy link
Contributor

@NewFuture NewFuture commented Oct 28, 2016 •
edited
Loading

Please check if the PR fulfills these requirements

  • An example has been added or updated in examples/ (for features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#672
#673

What is the new behavior?

works with ipv6 publicly!

and add doc to host-port.

@NewFuture NewFuture mentioned this pull request Oct 28, 2016
Closed
10 tasks
SpaceK33z
SpaceK33z approved these changes Oct 28, 2016
View reviewed changes
Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@SpaceK33z SpaceK33z merged commit 272c78a into webpack:master Oct 28, 2016
SpaceK33z added a commit that referenced this pull request Oct 29, 2016
@SpaceK33z
Fix incorrect URL when not using inline modus (introduced in #676)
36817dc
konstantib added a commit to konstantib/docs that referenced this pull request Apr 18, 2020
@konstantib
Added extra parameter to npm start script to avoid webpack-dev-server…
e835e15 
… ipv6 problem

When running the project as is using `npm start` no page was served on http://localhost:8080/ on my machine.
This is due to webpack-dev-server is using IPV4 and newer laptops and browsers are using IPV6.
The issue is fixed here: webpack/webpack-dev-server#676

Adding `--host ::` will ensure the project runs and serves the page correctly on newer browsers.
This was referenced Apr 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceK33z SpaceK33z SpaceK33z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NewFuture @SpaceK33z