fixed ipv6 ip parsing and listening at [::] #673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceK33z
requested changes
Oct 27, 2016
| @@ -272,8 +272,21 @@ function processOptions(wpOpt) { | |||
|
|
|||
| var protocol = options.https ? "https" : "http"; | |||
|
|
|||
| /** | |||
| * the formated uri of the webpack server | |||
There was a problem hiding this comment.
Can you remove this comment or make it more descriptive? Atm this tells me nothing more then I already know from looking at the code.
If you make it more descriptive, be sure to use // instead.
| pathname: options.inline !== false ? "/" : "webpack-dev-server/" | ||
| }); | ||
| //add the pathname of uri | ||
| uri += options.inline !== false ? "/" : "webpack-dev-server/" |
There was a problem hiding this comment.
Can you make this a separate variable instead? It's hackish to override the variable in this case since in query it's used for something else.
| if(options.inline !== false) { | ||
| var devClient = [require.resolve("../client/") + "?" + protocol + "://" + (options.public || (options.host + ":" + options.port))]; | ||
| /** | ||
| * client query url public or formated uri |
|
😃 well, it's changed. And some tips are added to the example doc. #676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
examples/(for features)What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
#672
What is the new behavior?
it works!
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
ipv6 all host [::] inline mode with error #672