Add unit tests for CLI and add flow compilation #186

evenstensberg · 2017-09-21T20:50:17Z

This PR enables us to test the webpack CLI as it stands in core, which in turns allows us to merge into the core repository

evenstensberg · 2017-09-21T21:10:58Z

Once this gets a ok to merge, we'd need to remove the local import, but it's to emphasize that the CLI tests runs well locally if you clone and run the branch.

evenstensberg · 2017-09-25T11:03:24Z

Could anyone review this?

okonet

I'm not sure why you have chosen Mocha for tests since we already have Jest in place.

Also, Jest allows create custom snaphotSerializers that would allow using snapshots to test the output.

Do you think you could switch your tests to Jest?

okonet · 2017-09-25T11:25:05Z

package.json

    "husky": "^0.14.3",
    "jest": "^20.0.4",
    "jest-cli": "^20.0.4",
-    "lint-staged": "^4.1.3"
+    "lint-staged": "^4.1.3",
+    "mocha": "^3.5.3",


We're using Jest for tests. Why is this needed?

okonet · 2017-09-25T11:25:20Z

package.json

+    "lint-staged": "^4.1.3",
+    "mocha": "^3.5.3",
+    "prettier-eslint-cli": "^4.3.2",
+    "should": "^13.1.0"


Same, jest already has everything we need.

evenstensberg · 2017-09-25T16:46:19Z

Yep, sure. Mocha was in old webpack, was easier to port those

evenstensberg · 2017-09-25T21:15:10Z

@okonet done!

ematipico · 2017-09-28T12:19:29Z

bin/convert-argv.js

+				options[name] = true;
+			}
+			//eslint-disable-next-line
+			if (name && options[name] == true) {


Shouldn't be ===?

Implemented by webpack/core. You should just look at the test for now

Also, let's keep it non-strict equal, cause it could be stringified

ematipico · 2017-09-29T20:21:24Z

test/BinTestCases.test.js

+const spawn = require("child_process").spawn;
+
+function loadOptsFile(optsPath) {
+	// Options file parser from Mocha


Comment can be removed as we decided to stick with Jest

Nice catch!

Actually, this should be kept, if you see next line

ematipico · 2017-09-29T20:42:07Z

Some tests are failing on Node 5 and 4

evenstensberg · 2017-09-29T20:43:33Z

Yep, cause we use include, changed in the feature PR

ematipico · 2017-09-29T20:45:04Z

Great, so it's under control :)

ematipico · 2017-09-29T20:38:12Z

bin/webpack.js

 var localCLI = resolveCwd.silent("webpack-cli/bin/webpack");

+if (process.argv.slice(2).includes("init")) {


.includes is not supported by Node 5 and 4. We need to change it. Also below
http://node.green/#ES2015-built-ins-well-known-symbols-Symbol-match--String-prototype-includes

evenstensberg · 2017-09-29T20:45:23Z

Any comments?

ematipico · 2017-09-29T20:46:26Z

It looks fine to me, there are just some conflicts but overall looks good

* Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files

# Conflicts: # bin/webpack.js # package.json

evenstensberg · 2017-09-29T22:23:50Z

V4 failing cause there's too many async operations going on, preventing the binCases to fully run. LGTM for now I guess. @ematipico your opinion?

ematipico · 2017-10-02T10:13:00Z

Fine by me. We also added the removing of the types before publishing, which is awesome!

* add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * rebase against master

* chore: Use prettier (#173) * build: Add webpack lint settings and style code with eslint --fix We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code * Add additional .eslintrc to /bin to remove unrelated eslint errors * build: Add jest-cli as dev dependency * style: fix lintin errors and coding style according to webpack settings * build: update dependencies and add package-lock to repo * feat: Require quotes only in property names that require it * chore: Add again removed settings by merge conflict solving * tests: Fix failing test * chore: Use husky instead of pre-commit pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json * [Feature] Added support to Flow inside transformations (#174) * [FLOW] Implemented interfaces and flow types inside the transformations * [FLOW] first commit * Added flwo to two other files * Reviewed interfaces * Created different intefaces for expressions * Fixed rest of trasformations * More developments * Updated code after code review * Fixed failing tests * Removed yarn file * Applied linting * Updated packages * Applied lint style to the imports due to code review * docs: Documentation for migrate (#175) * initial draft of migrate documentation * formatting * formatting * added summary of migrate changes * maintain consistent usage of user through documentation * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * Add unit tests for CLI and add flow compilation (#186) * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * rebase against master * ast for devServer (#185) * feat: replace yarn backup w/ normal yarn (#160) * feat: replace yarn backup w/ normal yarn * upgrade npm & remove yarn * Use yarn if available (#189) * bump version to 1.3.4 * update package.json * 1.3.5 * prepublish -> postinstall * 1.3.6 * temp fix to prepublish issue * 1.3.7 * add propper post install * 1.3.8 * re-add manual build step * 1.3.9 * refactor * bump version * disable published pkg * add ignore patterns * add more ignore patterns for npm

evenstensberg added 3 commits September 21, 2017 22:49

add unit tests for everything and flow compilation

af076d9

add travis builds

72ff372

add cli to signature & add ignore to trash code

0b36271

evenstensberg requested a review from okonet September 24, 2017 13:35

okonet suggested changes Sep 25, 2017

View reviewed changes

port to jest

18a4df1

remove redundant cli command

e72bc10

ematipico reviewed Sep 28, 2017

View reviewed changes

ematipico reviewed Sep 29, 2017

View reviewed changes

ematipico approved these changes Sep 29, 2017

View reviewed changes

ianjsikes and others added 8 commits September 29, 2017 23:59

add unit tests for everything and flow compilation

5d0859a

add travis builds

4667661

add cli to signature & add ignore to trash code

ee9a9e9

port to jest

41f5ee4

remove redundant cli command

c67eb0c

rebase against master

6b5d432

resolve conflicts

7382018

# Conflicts: # bin/webpack.js # package.json

andrei-zhidkov mentioned this pull request Oct 1, 2017

Adding a build step #188

Closed

evenstensberg merged commit c8633c0 into master Oct 5, 2017

evenstensberg deleted the cli-tests branch October 5, 2017 20:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests for CLI and add flow compilation #186

Add unit tests for CLI and add flow compilation #186

evenstensberg commented Sep 21, 2017 •

edited

Loading

evenstensberg commented Sep 21, 2017

evenstensberg commented Sep 25, 2017

okonet left a comment

okonet Sep 25, 2017

okonet Sep 25, 2017

evenstensberg commented Sep 25, 2017

evenstensberg commented Sep 25, 2017

ematipico Sep 28, 2017

evenstensberg Sep 29, 2017

evenstensberg Sep 29, 2017

ematipico Sep 29, 2017

evenstensberg Sep 29, 2017

evenstensberg Sep 29, 2017

ematipico commented Sep 29, 2017

evenstensberg commented Sep 29, 2017

ematipico commented Sep 29, 2017

ematipico Sep 29, 2017

evenstensberg commented Sep 29, 2017

ematipico commented Sep 29, 2017

evenstensberg commented Sep 29, 2017 •

edited

Loading

ematipico commented Oct 2, 2017

		var localCLI = resolveCwd.silent("webpack-cli/bin/webpack");

		if (process.argv.slice(2).includes("init")) {

Add unit tests for CLI and add flow compilation #186

Add unit tests for CLI and add flow compilation #186

Conversation

evenstensberg commented Sep 21, 2017 • edited Loading

evenstensberg commented Sep 21, 2017

evenstensberg commented Sep 25, 2017

okonet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Sep 25, 2017

evenstensberg commented Sep 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico commented Sep 29, 2017

evenstensberg commented Sep 29, 2017

ematipico commented Sep 29, 2017

Choose a reason for hiding this comment

evenstensberg commented Sep 29, 2017

ematipico commented Sep 29, 2017

evenstensberg commented Sep 29, 2017 • edited Loading

ematipico commented Oct 2, 2017

evenstensberg commented Sep 21, 2017 •

edited

Loading

evenstensberg commented Sep 29, 2017 •

edited

Loading