Chore/prettify and lint #173

DanielaValero · 2017-07-18T13:00:31Z

What kind of change does this PR introduce?

Build feature: Uses the webpack eslint config. Edits some settings, that make sense to have in the cli. Example no warning when we use console.log
Uses eslint --fix to beautify code. In webpack they are using beautify-lint however it seems to me that it does the same than eslint --fix, therefore left only the one of eslint
Chore: Fixes all lintin errors in the code base
Updates all the dependencies
Removed fix-commit-js as it is not really working

note Wanted to use prettier for the automatic prettification of the code, but was quite complicated. More details here: #102 (comment)

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Does this PR introduce a breaking change?

Nope

We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code

DanielaValero · 2017-07-18T13:23:21Z

Hi guys,

I noticed the broken tests, which are also broken in master. If apart from that, the PR is good for you, I'd suggest to get it merged. As it touches many files, the longer we take to merge it, the more merge conflicts we'll get here.

I will start right away a RP with the fixes for the broken tests.

okonet · 2017-07-19T09:36:22Z

package.json

-    ]
-  },
-  "pre-commit": "lint:staged",
-  "jest": {


Did you drop this intentionally?

Oh, good finding! did not want to drop it, was in the merge conflict solving, etc, etc

okonet · 2017-07-19T09:37:58Z

package.json

+    "babel-polyfill": "^6.23.0",
+    "eslint": "^4.2.0",
+    "eslint-plugin-node": "^5.1.0",
+    "eslint-plugin-prettier": "^2.1.2",


I see this dependency but I could not find the reference to it anywhere. Did you forget to add it to eslintrc?

I forgot to remove it, I had added it when I was trying to add prettier to automatically style our code, but after I figured out that prettier is not yet there, removed it, and forgot to get it out from the dependencies.

DanielaValero · 2017-07-20T14:43:17Z

@okonet added your comments, it's ready for a second look

evenstensberg · 2017-07-29T16:46:44Z

Could you rebase against master, as the snapshot tests are making the CI fail?

DanielaValero · 2017-07-29T17:11:49Z

Hi @ev1stensberg

The branch is already up-to-date, the tests are also failing in the master branch. Once this is merged, I'll check them out, to make a PR fixing them

evenstensberg · 2017-07-29T17:19:17Z

Gotcha ✌️

DanielaValero · 2017-08-01T08:33:59Z

Hello @ev1stensberg @okonet As there is no more comment on this PR, would it be possible to merge it?

Otherwise, let me know what the blocker issue is, so I can apply it, and get this in asap.

There are many touched files, and the longer we wait to merge it, the more extra not necessary work will be raised

evenstensberg · 2017-08-01T15:12:23Z

Haven't had a chance to test this, could it chill until tomorrow?

DanielaValero · 2017-08-01T16:14:28Z

@ev1stensberg sure! :) Thanks for taking the time

evenstensberg · 2017-08-03T18:52:25Z

Could you do rm -rf node_modules && npm install ? Otherwise, lgtm

ematipico · 2017-09-12T16:12:08Z

Would it be possible to merge the PR? I'd like to have it merged as I am working on implementing Flow. This could generate conflicts and since this PR has been already reviewed, I'd like to rebase on it. Cheers!

okonet · 2017-09-12T20:13:37Z

Some tests are failing for this PR. I'm not sure if it's because of those changes or not.

okonet · 2017-09-12T20:16:24Z

~~I'll look at test and merge this one.~~

@DanielaValero you mentioned that tests are failing on the master branch but I can't reproduce that.

okonet · 2017-09-12T20:23:21Z

lib/creator/transformations/context/context.js

+					j,
+					p,
+					utils.pushCreateProperty,
+					"context",


~~So FYI this is what was breaking the test.~~ Nope. Looking further.

okonet · 2017-09-12T20:25:39Z

lib/creator/transformations/context/context.test.js

-defineTest(__dirname, 'context', 'context-2', 'contextVariable');
+const defineTest = require("../../../transformations/defineTest");
+
+defineTest(__dirname, "context", "context-0", "path.resolve(__dirname, 'app')");


This one is to blame!

pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json

* build: Add webpack lint settings and style code with eslint --fix We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code * Add additional .eslintrc to /bin to remove unrelated eslint errors * build: Add jest-cli as dev dependency * style: fix lintin errors and coding style according to webpack settings * build: update dependencies and add package-lock to repo * feat: Require quotes only in property names that require it * chore: Add again removed settings by merge conflict solving * tests: Fix failing test * chore: Use husky instead of pre-commit pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json

* chore: Use prettier (#173) * build: Add webpack lint settings and style code with eslint --fix We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code * Add additional .eslintrc to /bin to remove unrelated eslint errors * build: Add jest-cli as dev dependency * style: fix lintin errors and coding style according to webpack settings * build: update dependencies and add package-lock to repo * feat: Require quotes only in property names that require it * chore: Add again removed settings by merge conflict solving * tests: Fix failing test * chore: Use husky instead of pre-commit pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json * [Feature] Added support to Flow inside transformations (#174) * [FLOW] Implemented interfaces and flow types inside the transformations * [FLOW] first commit * Added flwo to two other files * Reviewed interfaces * Created different intefaces for expressions * Fixed rest of trasformations * More developments * Updated code after code review * Fixed failing tests * Removed yarn file * Applied linting * Updated packages * Applied lint style to the imports due to code review * docs: Documentation for migrate (#175) * initial draft of migrate documentation * formatting * formatting * added summary of migrate changes * maintain consistent usage of user through documentation * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * Add unit tests for CLI and add flow compilation (#186) * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * rebase against master * ast for devServer (#185) * feat: replace yarn backup w/ normal yarn (#160) * feat: replace yarn backup w/ normal yarn * upgrade npm & remove yarn * Use yarn if available (#189) * bump version to 1.3.4 * update package.json * 1.3.5 * prepublish -> postinstall * 1.3.6 * temp fix to prepublish issue * 1.3.7 * add propper post install * 1.3.8 * re-add manual build step * 1.3.9 * refactor * bump version * disable published pkg * add ignore patterns * add more ignore patterns for npm

DanielaValero and others added 6 commits July 18, 2017 15:02

build: Add webpack lint settings and style code with eslint --fix

1f5a964

We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code

build: update dependencies and add package-lock to repo

43603c4

build: Add jest-cli as dev dependency

2990b40

style: fix lintin errors and coding style according to webpack settings

445125f

Add additional .eslintrc to /bin to remove unrelated eslint errors

283a0b0

feat: Require quotes only in property names that require it

8aca6a2

DanielaValero force-pushed the chore/prettify-and-lint branch from dcc43d8 to 8aca6a2 Compare July 18, 2017 13:20

DanielaValero requested a review from okonet July 18, 2017 13:23

This was referenced Jul 18, 2017

[WIP] E2E tests for init and migrate using docker and soren #169

Closed

feat: replace yarn backup w/ normal yarn #160

Merged

okonet suggested changes Jul 19, 2017

View reviewed changes

DanielaValero mentioned this pull request Jul 20, 2017

Introduce beautify-lint and reformat files automatically #102

Closed

chore: Add again removed settings by merge conflict solving

e7c1109

okonet approved these changes Jul 26, 2017

View reviewed changes

evenstensberg approved these changes Aug 3, 2017

View reviewed changes

okonet reviewed Sep 12, 2017

View reviewed changes

tests: Fix failing test

d23f4a9

Andrey Okonetchnikov added 2 commits September 12, 2017 22:37

chore: Use husky instead of pre-commit

d306fd5

pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json

Merge branch 'master' into chore/prettify-and-lint

0719001

okonet merged commit b3186a9 into master Sep 13, 2017

okonet deleted the chore/prettify-and-lint branch September 13, 2017 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/prettify and lint #173

Chore/prettify and lint #173

DanielaValero commented Jul 18, 2017 •

edited

Loading

DanielaValero commented Jul 18, 2017

okonet Jul 19, 2017

DanielaValero Jul 20, 2017

okonet Jul 19, 2017

DanielaValero Jul 20, 2017

DanielaValero commented Jul 20, 2017

evenstensberg commented Jul 29, 2017

DanielaValero commented Jul 29, 2017

evenstensberg commented Jul 29, 2017

DanielaValero commented Aug 1, 2017

evenstensberg commented Aug 1, 2017

DanielaValero commented Aug 1, 2017

evenstensberg commented Aug 3, 2017

ematipico commented Sep 12, 2017

okonet commented Sep 12, 2017

okonet commented Sep 12, 2017 •

edited

Loading

okonet Sep 12, 2017 •

edited

Loading

okonet Sep 12, 2017

Chore/prettify and lint #173

Chore/prettify and lint #173

Conversation

DanielaValero commented Jul 18, 2017 • edited Loading

DanielaValero commented Jul 18, 2017

okonet Jul 19, 2017

Choose a reason for hiding this comment

DanielaValero Jul 20, 2017

Choose a reason for hiding this comment

okonet Jul 19, 2017

Choose a reason for hiding this comment

DanielaValero Jul 20, 2017

Choose a reason for hiding this comment

DanielaValero commented Jul 20, 2017

evenstensberg commented Jul 29, 2017

DanielaValero commented Jul 29, 2017

evenstensberg commented Jul 29, 2017

DanielaValero commented Aug 1, 2017

evenstensberg commented Aug 1, 2017

DanielaValero commented Aug 1, 2017

evenstensberg commented Aug 3, 2017

ematipico commented Sep 12, 2017

okonet commented Sep 12, 2017

okonet commented Sep 12, 2017 • edited Loading

okonet Sep 12, 2017 • edited Loading

Choose a reason for hiding this comment

okonet Sep 12, 2017

Choose a reason for hiding this comment

DanielaValero commented Jul 18, 2017 •

edited

Loading

okonet commented Sep 12, 2017 •

edited

Loading

okonet Sep 12, 2017 •

edited

Loading