Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate errors on the client overlay #140

Merged
merged 2 commits into from
Nov 7, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Nov 7, 2016

This will fix the issue: storybookjs/storybook#543

We do this by using stats.toJson({ errorDetails: false }) as mentioned by @SpaceK33z.
I tested this with Storybook and the above issue is gone with this fix.

This will fix the issue of print duplicate errors on the client.
@coveralls
Copy link

coveralls commented Nov 7, 2016

Coverage Status

Coverage remained the same at 76.51% when pulling 14d1ffc on arunoda:patch-1 into 04f953d on glenjamin:master.

@glenjamin glenjamin merged commit e0a0c46 into webpack-contrib:master Nov 7, 2016
@glenjamin
Copy link
Collaborator

How odd, I've never seen this myself. The extra detail must be in a newer Babel version I guess.

Cool to see that storybook is using hot-middleware too.

Will cut a new release in the morning.

@arunoda
Copy link
Contributor Author

arunoda commented Nov 7, 2016

We were using hot-middleware from the beginning.
Looking forward for the release.

@glenjamin
Copy link
Collaborator

Released as v2.13.2.

Hopefully there was nothing else useful in the errorDetails 😅

@SpaceK33z
Copy link

Nice. In my manual tests it didn't seem like there is anything useful in errorDetails. At least babel-loader, css-loader, sass-loader don't include useful info it.

I'm also going to release the same fix for webpack-dev-server soon. Would appreciate it if you would notify me if it turns out to include useful info 😈 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants