Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display errors twice with create react app #543

Closed
sylvainbannier opened this issue Oct 12, 2016 · 7 comments
Closed

display errors twice with create react app #543

sylvainbannier opened this issue Oct 12, 2016 · 7 comments
Labels

Comments

@sylvainbannier
Copy link

I freshly installed storybook on create-react-app with getstorybook.

here's the brouwser output of npm start (CRA) when there's a missing closing tag for instance :
image

And here's the browser output of npm run storybook with the same kind of issue :
image

I see some issues with that output :

  1. the error is displayed twice
  2. the text error doesn't wrap (tested in full screen mode too)
  3. there's some irrelevant information at the end regarding babel
@arunoda arunoda added the bug label Oct 12, 2016
@arunoda
Copy link
Member

arunoda commented Oct 13, 2016

@roonyh could you look into this?

@roonyh
Copy link
Contributor

roonyh commented Oct 13, 2016

Sure. Working on it.

@roonyh
Copy link
Contributor

roonyh commented Oct 13, 2016

I used the example project from webpack-hot-middleware and used babel-loader on it. It shows errors in the exact same format.

So this seems like its not fixable from inside storybook. I'll leave this for now to work on some higher priority issues.

We have plans for a error reporting system of our own, like the one create-react-app have. If someone can contribute with anything on something like that, PRs are welcome! :)

@SpaceK33z
Copy link
Member

Hi, I'm a team member of webpack and I recently debugged an issue that looks very much like this: webpack/webpack#3008. I don't know what package you use exactly to show the error like that, but the package should use stats.toJson({ errorDetails: false }) to fix it.

@arunoda
Copy link
Member

arunoda commented Nov 7, 2016

Hi @SpaceK33z
I hope this is coming from webpack-dev-middleware.
( I assume you work on that project too)

Let me try to update it.

EDIT: I think https://github.com/glenjamin/webpack-hot-middleware could be the problem.

@arunoda
Copy link
Member

arunoda commented Nov 7, 2016

@SpaceK33z Thanks for the input.
I added your suggestion and it works.
Sent a PR: webpack-contrib/webpack-hot-middleware#140

@arunoda arunoda closed this as completed in 7b29eaf Nov 8, 2016
@arunoda
Copy link
Member

arunoda commented Nov 8, 2016

Released the fix as v2.29.4.
Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants