pluginColors option to enable/disable plugin coloring of stylint output
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the option to `false` to prevent the plugin from forcing a coloring output, and let the chosen formatter handle it 100%.
|
Thanks for the PR, @Leimi! Could you rebase and try adding this again? #17 did some restructuring while fixing the stylelint v7 issues. :) It would be really cool to see a test for this as well, perhaps using testdouble to check whether or not the colouring function was called when expected. Thanks again! |
JaKXz
suggested changes
Dec 17, 2016
|
Closing due to inactivity - please feel free to re-fork and start this again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your plugin :)
I noticed lint outputs were different when using directly stylelint vs the webpack plugin. I'd rather have the plugin don't affect at all how stylelint output things, and let the formatter handle it.
If it were only me I'd totally delete the coloring done by the plugin, but in order to preserve current behavior I added a
pluginColorsoption to handle that.What do you think?