-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring with linting and coverage #17
Restructuring with linting and coverage #17
Conversation
and add missing use strict
Hi @JaKXz! Thank you very much for all the work! And sorry for the late response, I took some days off. I'm in favour of merging this PR, but before that there is one thing I would like to change: Why removing My suggestion is to add it back with a semver range, like What do you think? Thanks again! |
@vieron no worries, glad you're back :) I think removing
EDIT: The good thing is that this can be release v0.3.0 which will be a breaking change for those with |
@JaKXz as you said And regarding the second point, for me, it also applies when not specifying a stylelint version. You rely on any version the user has installed. It's like saying all versions are supported, but we just run test against v7. I still think we should add the peerDependency, just depending in |
Fair enough, good point - I'll add it back and merge :) |
Published |
* Update stylelint dependency * Fix renamed rules in stylelint v7 * Add editorconfig * Simplify linter * Use chai array length assertion * Restructure with linting and coverage * Add some documentation for runCompilation and add missing use strict * Keep stylelint v7 in peerDependencies
Fixes #14.
Closes #15.
Hi @vieron, while writing #15 I was having some trouble debugging so I went a bit crazy and restructured things. I figured I should at least separate these things into different PRs so we can get the update/fix merged and published.
This might make for a good 1.0.0 so that you know where the coverage stands and so on.EDIT: I'd definitely recommend only squash-merging EITHER #15 or this. Thanks!