Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use a version of Python that node-sass can be built on for macOS #1215

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 20, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

It seems like there isn't a precompiled version of node-sass available for macos-latest, and node-gpy then fails to build it from source due to the version not being compatible with Python 3.12.

It seems like this might be the last straw for node-sass but in the meantime we can work around this by just explicitly installing an older version of Python when running on macos-latest.

Breaking Changes

This is not a breaking change

Additional Info

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (31789cc) to head (9cb327d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   94.44%   93.93%   -0.52%     
==========================================
  Files           3        3              
  Lines         360      412      +52     
  Branches      132      153      +21     
==========================================
+ Hits          340      387      +47     
- Misses         18       23       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath marked this pull request as ready for review July 21, 2024 00:51
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@evenstensberg evenstensberg merged commit 0f3a056 into webpack-contrib:master Jul 21, 2024
10 of 11 checks passed
@G-Rath G-Rath deleted the fix-node-sass branch July 21, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants