Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't cancel in-progress jobs in matrix if others fail #1213

Closed
wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 20, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Matrixes "fail fast" by default, which can be annoying as failures in linting and the test suite by the time a pull request are technically expected to be because of one specific dimension (e.g. an os, since most people don't develop on multiple os's at the same time) - so this disables that :)

Breaking Changes

Not a breaking change

Additional Info

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (31789cc) to head (701f77a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
- Coverage   94.44%   93.93%   -0.52%     
==========================================
  Files           3        3              
  Lines         360      412      +52     
  Branches      132      155      +23     
==========================================
+ Hits          340      387      +47     
- Misses         18       23       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fail fast is good. When the CI fails, you'll most likely have to rerun the jobs anyway

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 21, 2024

Yes, but you're more likely to have to re-run it more because you might have os-specific failures - for example I won't know if #1211 is going to pass on any OSs because the macOS job failed; now that #1215 is landed that should be unblocked but now I'll just learn if any-but-not-all of the OSs are passing (and repeat until all jobs are passing...)

Ultimately up to you though - please do close this PR if you'd still prefer to keep fail-fast enabled :)

@evenstensberg
Copy link
Member

I think we will close this, but thank you so much for the contribution, appreciate you!

@G-Rath G-Rath deleted the dont-fail-fast branch July 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants